Skip to content

Fix ClientSession swallowing exceptions in default message_handler - #3366

Closed
mayuriphad wants to merge 1 commit into
modelcontextprotocol:mainfrom
mayuriphad:fix-session-error-handler
Closed

Fix ClientSession swallowing exceptions in default message_handler#3366
mayuriphad wants to merge 1 commit into
modelcontextprotocol:mainfrom
mayuriphad:fix-session-error-handler

Conversation

@mayuriphad

Copy link
Copy Markdown

Fixes #1401 by raising \Exception\ messages passed into the default \message_handler\ instead of swallowing them. This ensures stream errors propagate out of the \ClientSession\ by default.

Copilot AI lite review requested due to automatic review settings August 23, 2026 15:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution. This repository only keeps pull requests open when they're linked to an issue that a maintainer has assigned to the author — CONTRIBUTING.md explains why and how we work. This PR has been closed for now because you aren't currently assigned to #1401.

If a maintainer would like this change as a PR from you, they'll assign you to #1401 and this PR will reopen automatically — there's nothing more you need to do. (If you opened the issue, this PR already shows up on its timeline.)

There's no need to open a new PR — this one will be reopened. While it's closed, please push any updates as new commits rather than force-pushing, since GitHub can't reopen a PR whose branch has been rewritten.

Maintainers: reopening this PR, removing the missing-issue-link label, or adding bypass-issue-check bypasses the check.

@github-actions github-actions Bot closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientSession Error Handling

2 participants