Enable context injection into resources#248
Closed
jonvet wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Enable context injection into resources#248jonvet wants to merge 1 commit intomodelcontextprotocol:mainfrom
jonvet wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
|
I tested this and it works for me |
3 tasks
|
@dsp-ant any updates with this one? useful for me |
|
Waiting for this to be fixed too 🫶 |
9 tasks
2cc3e0e to
16a6ac0
Compare
748ea91 to
488a6d6
Compare
488a6d6 to
b5aa983
Compare
Author
|
@dsp-ant is there anything we can do to get a review on this PR? |
There was a problem hiding this comment.
Thank you for your contribution to the MCP Python SDK! This is a valuable fix that enables resource functions to properly access the Context object, bringing them on par with tools.
As noted by project members, the implementation is working well for the basic case of injecting the Context. However, PR #413 has been created as a rebased version of your PR and is already being tracked in a milestone. Given that the code changes are essentially the same, we'll proceed with PR #413 to avoid duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #244
Motivation and Context
According to the readme it should be possible to pass a
Contextto a resource (like it is for tools), but that's currently throwing an error (#244)How Has This Been Tested?
Added tests, and confirmed with inspector that the below demo server works as intended:
Breaking Changes
Types of changes
Checklist
Additional context
I tried to follow a similar structure to the way context is injected in tools