fix: validate_scope should allow all scopes when no restriction#2246
Open
goingforstudying-ctrl wants to merge 141 commits intomodelcontextprotocol:mainfrom
Open
fix: validate_scope should allow all scopes when no restriction#2246goingforstudying-ctrl wants to merge 141 commits intomodelcontextprotocol:mainfrom
goingforstudying-ctrl wants to merge 141 commits intomodelcontextprotocol:mainfrom
Conversation
2 tasks
When client registration has scope=None (no restriction), validate_scope was incorrectly rejecting all requested scopes by treating None as an empty allowed list. Now when scope is None, all requested scopes are allowed, which matches the expected behavior described in the auth flow. Fixes modelcontextprotocol#2216
goingforstudying-ctrl
force-pushed
the
fix/validate-scope-none-handling
branch
from
e65bd53 to
2a0938a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2216
When client registration has scope=None (no restriction), validate_scope() was incorrectly rejecting all requested scopes by treating None as an empty allowed list.
Changes:
/attempt #2216