Broaden authorization server discovery to include OIDC fallbacks#1786
Closed
sonmaximum wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
Broaden authorization server discovery to include OIDC fallbacks#1786sonmaximum wants to merge 3 commits intomodelcontextprotocol:mainfrom
sonmaximum wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
Member
|
see comment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
build_oauth_authorization_server_metadata_discovery_urlsso that the MCP client always probes both OAuth and OpenID discovery endpoints, with path-aware variants and deduplication. This lets the client interoperate with authorization servers that only expose/.well-known/openid-configuration.Change Details
auth_server_url or server_urlas a single source of truth, so we always consider the configured base when no metadata URL is advertised./.well-known/openid-configuration{path}){path}/.well-known/openid-configuration)Motivation and Context
path == "/"or when config already points at a well-known URL.How Has This Been Tested?
resource_metadata, base URLhttps://idp.example.com-> probes both OAuth and OIDC root well-known endpoints.auth_server_urllikehttps://idp.example.com/tenantA-> probes path-aware OAuth/OIDC endpoints plus root fallbacks without duplicates.Types of change
(either depending on perspective?)
Checklist
Additional context
See related issue #1785