Lazy import sse_starlette to reduce import time#1771
Closed
CNSeniorious000 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
Lazy import sse_starlette to reduce import time#1771CNSeniorious000 wants to merge 2 commits intomodelcontextprotocol:mainfrom
sse_starlette to reduce import time#1771CNSeniorious000 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes module import time by implementing lazy imports for sse_starlette.EventSourceResponse, which prevents the early loading of the uvicorn dependency when the mcp module is imported. The changes move the import statements from module level to function/method level, placing them right before EventSourceResponse is used.
Key Changes:
- Removed top-level
from sse_starlette import EventSourceResponseimports - Added function-level lazy imports in four locations where
EventSourceResponseis used - Maintains consistent pattern across both
sse.pyandstreamable_http.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/mcp/server/sse.py |
Moved EventSourceResponse import inside response_wrapper function within connect_sse method |
src/mcp/server/streamable_http.py |
Added three lazy imports for EventSourceResponse in _handle_post_request, _handle_get_request, and _replay_events methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
from sse_starlette import EventSourceResponseto whereEventSourceResponseis used to defer importinguvicorn.Motivation and Context
Fixes #1770
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context