feat: standardize timeout values to floats in seconds#1766
Merged
maxisbey merged 4 commits intomodelcontextprotocol:mainfrom Dec 19, 2025
Merged
feat: standardize timeout values to floats in seconds#1766maxisbey merged 4 commits intomodelcontextprotocol:mainfrom
maxisbey merged 4 commits intomodelcontextprotocol:mainfrom
Conversation
36b964b to
faff0bb
Compare
Contributor
|
Thanks - as you mentioned this is a breaking change but we're starting work on that now, so marking this as draft for now and have added it to our internal tracking, we'll come back to this. |
- Convert all timeout parameters from timedelta to float type - Update StreamableHttpParameters, SseServerParameters timeouts to float - Change read_timeout_seconds from timedelta | None to float | None - Remove timedelta imports from modified files - Update examples and tests to use float values (e.g., 30.0 instead of timedelta(seconds=30)) - Add '(in seconds)' clarification to all timeout parameter docstrings - Align with Python ecosystem conventions (httpx, starlette, stdlib) BREAKING CHANGE: All timeout parameters now accept float (seconds) instead of timedelta objects Fixes modelcontextprotocol#1747
- Fix test_response_id_non_numeric_string_no_match to use float (0.5) instead of timedelta(seconds=0.5) - Resolves TypeError: unsupported operand type(s) for +: 'float' and 'datetime.timedelta'
7ae5b03 to
9873cbf
Compare
- Remove .total_seconds() calls in session_group.py (values are now floats) - Update test_streamable_http.py to use float timeout values - Change timeout=60 to timeout=60.0 in simple-auth-client example - Change timeout=10 to timeout=10.0 in test_session_group.py
maxisbey
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize timeout values to floats in seconds
Summary
Standardizes all timeout parameters across the SDK to use
floatvalues representing seconds, following Python ecosystem conventions (httpx, starlette, stdlib).Motivation and Context
timedeltaandfloattypesChanges Made
timedelta | Nonetofloat | NoneStreamableHttpParametersandSseServerParametersto use float valuestimedeltaimports and conversion logicFiles Modified: 9 files across core SDK, examples, and tests
How Has This Been Tested?
Breaking Changes
YES - This is a breaking change for v2
Migration:
Replace
timedelta(seconds=X)withX.0and remove unusedtimedeltaimports.Types of changes
Checklist
Additional context
Default Timeout Values:
5.0seconds300.0seconds (5 minutes)30.0seconds300.0seconds (5 minutes)Design: Aligns with Python ecosystem standards, maintains equivalent behavior, uses explicit
.0notation for clarity.Fixes #1747