fix: handle BrokenResourceError in stdio_client#1749
Closed
Pavithra-Madhan wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
fix: handle BrokenResourceError in stdio_client#1749Pavithra-Madhan wants to merge 2 commits intomodelcontextprotocol:mainfrom
Pavithra-Madhan wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes
BrokenResourceErrorcrashes instdio_clientduring shutdown and improvesClientSessionsafety.Changes
Fixed
BrokenResourceErrorinstdio_client: Wrapsread_stream_writer.send()calls instdout_reader()with try/except blocks to handle stream closure gracefully during TaskGroup shutdown.Added
ClientSessionvalidation: Added_enteredflag check ininitialize()to ensure the session is used within anasync withcontext manager, preventing misuse.Why
stdout_reader()would crash trying to send to closed streams → confusingExceptionGrouperrors.ClientSession.initialize()could be called without proper context manager setup.Notes
Discovered that Python subprocesses require
-uflag for unbuffered stdio communication (separate consideration).Testing note
During testing, discovered that FastMCP servers return a "Received request before initialization was complete" - a separate timing issue in their implementation.