Make refresh_token grant type optional in DCR handler#1651
Merged
pcarleton merged 10 commits intomodelcontextprotocol:mainfrom Jan 5, 2026
Merged
Make refresh_token grant type optional in DCR handler#1651pcarleton merged 10 commits intomodelcontextprotocol:mainfrom
pcarleton merged 10 commits intomodelcontextprotocol:mainfrom
Conversation
Updated the Dynamic Client Registration (DCR) handler to comply with RFC 7591 by making the refresh_token grant type optional. Previously, the handler incorrectly required both authorization_code and refresh_token grant types, which was unnecessarily restrictive and non-compliant with the RFC. Changes: - Modified grant_types validation to only require authorization_code - Updated error message to reflect the new requirement - Renamed test to test_client_registration_with_authorization_code_only - Added test for missing authorization_code (now the true error case) - Updated test assertions to match new validation behavior This change improves RFC 7591 compliance and provides clients with greater flexibility in their registration options. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Github-Issue: modelcontextprotocol#1650
felixweinberger
added
auth
maxisbey
added
the
P2
2 tasks
pcarleton
approved these changes
Jan 5, 2026
Member
pcarleton
left a comment
pcarleton
left a comment
There was a problem hiding this comment.
thanks! agree refresh token is not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Dynamic Client Registration (DCR) handler to comply with RFC 7591 by making the refresh_token grant type optional. Previously, the handler incorrectly required both authorization_code and refresh_token grant types, which was unnecessarily restrictive and non-compliant with the RFC.
Changes:
This change improves RFC 7591 compliance and provides clients with greater flexibility in their registration options.
Github-Issue: #1650