Fix issue where client tool call hangs forever if server crashes or connection dies when using streamable-http#1578
Open
gyang-xai wants to merge 9 commits intomodelcontextprotocol:mainfrom
Conversation
gyang-xai
force-pushed
the
streamable_http_disconnection_fix
branch
2 times, most recently
from
f1be402 to
245c47a
Compare
gyang-xai
force-pushed
the
streamable_http_disconnection_fix
branch
from
245c47a to
f2d0cc2
Compare
Author
|
@maxisbey I have merged in the latest changes can you review? This is still an issue with the most recent version. |
maxisbey
added
the
P2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #1577
Motivation and Context
Fixes issue where some errors are not propagated back to the tool call.
How Has This Been Tested?
Tested with the example in the issue.
Breaking Changes
No
Types of changes
Checklist
Additional context
I have tested this with tool calls but unsure if this works for the other resource types.