fix: accept HTTP 201 status code in token exchange#1503
Merged
pcarleton merged 4 commits intomodelcontextprotocol:mainfrom Dec 19, 2025
Merged
fix: accept HTTP 201 status code in token exchange#1503pcarleton merged 4 commits intomodelcontextprotocol:mainfrom
pcarleton merged 4 commits intomodelcontextprotocol:mainfrom
Conversation
Fixes modelcontextprotocol#1502 Some OAuth servers (like Supabase) return 201 Created instead of 200 OK for successful token exchanges. The OAuth 2.0 spec doesn't mandate a specific success status code, so we should accept both 200 and 201.
jnjpng
force-pushed
the
fix-oauth-token-status-codes
branch
from
3c482be to
27d1566
Compare
felixweinberger
added
bug
pcarleton
requested changes
Oct 24, 2025
Member
pcarleton
left a comment
pcarleton
left a comment
There was a problem hiding this comment.
change looks good, can you please add a test?
felixweinberger
added
the
needs more work
Contributor
Author
|
@pcarleton done! let me know if this look good |
felixweinberger
added
enhancement
Contributor
Author
|
@pcarleton what's the status on this? |
pcarleton
previously approved these changes
Dec 19, 2025
pcarleton
approved these changes
Dec 19, 2025
Member
|
@jnjpng sorry about that, missed the ping on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept HTTP 201 status code in addition to 200 for successful OAuth token exchanges.
Motivation and Context
Fixes #1502, some OAuth servers (like Supabase) return 201 Created instead of 200 OK for successful token exchanges. The OAuth 2.0 spec doesn't mandate a specific success status code, so we should accept both 200 and 201.
How Has This Been Tested?
Tested locally against remote MCP servers that return this status code, and ran the tests specified in the contribution guide.
Breaking Changes
No.
Types of changes
Checklist
Additional context