[WIP][POC] Update logic for constructing protected resource metadata URL to include the resource's path component, for compatibility with Oauth RFCs#1179
Closed
smurching wants to merge 5 commits intomodelcontextprotocol:mainfrom
Conversation
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
smurching
commented
Jul 21, 2025
| await self._handle_protected_resource_response(discovery_response) | ||
| break # Success, stop trying other URLs | ||
| elif discovery_response.status_code != 404: | ||
| break # Non-404 error, stop trying |
Author
There was a problem hiding this comment.
In practice we may want to keep retrying on other types of errors too, just to be safe
Contributor
|
Hi @smurching thank you for this contribution - discussed internally with @pcarleton as we have another PR #1334 open that tackles the same issue. We think #1334 is the right approach here, so closing this one for now - please feel free to chime in on that PR if you have thoughts on the approach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update logic for constructing the protected resource metadata URL for an MCP server to include the path component of the resource being accessed, as per section 3.1 of Oauth RFC 9728:
To avoid breaking changes, we first attempt RFC-compliant behavior, e.g. for
https://api.example.com/mcp, first try to query a PRM endpoint athttps://api.example.com/.well-known/oauth-protected-resource/mcp. If that fails, we then fall back to queryinghttps://api.example.com/.well-known/oauth-protected-resource(existing behavior, excluding the/mcppath component)How Has This Been Tested?
Updated unit tests - TODO test this against some real example servers
Breaking Changes
Types of changes
Checklist
Additional context