fix: Return JSON-RPC protocol errors for unknown tools#1149
Closed
bzsurbhi wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix: Return JSON-RPC protocol errors for unknown tools#1149bzsurbhi wants to merge 1 commit intomodelcontextprotocol:mainfrom
bzsurbhi wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
ihrpr
requested changes
Jul 21, 2025
Contributor
ihrpr
left a comment
There was a problem hiding this comment.
Thank you for the fix!
Please update the error code to types.INVALID_PARAMS. Additionally, consider adding test cases for edge cases like empty or null tool names.
| if tool is None: | ||
| raise McpError( | ||
| types.ErrorData( | ||
| code=types.METHOD_NOT_FOUND, |
Contributor
There was a problem hiding this comment.
Tool name in the request is a parameter (the method is tools/call), hence I'd suggest to change to INVALID_PARAMS (-32602) to be consistent with the spec https://modelcontextprotocol.io/specification/2025-06-18/server/tools#error-handling and Typescript SDK
Contributor
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return JSON-RPC protocol errors for unknown tools
Motivation and Context
The MCP server was returning tool execution errors for unknown tools instead of proper JSON-RPC protocol errors. This caused issues where Unknown tools were treated as tool execution failures rather than protocol-level errors
Before(Tool execution error):
After(Protocol error):
Modified the tool call handler in src/mcp/server/lowlevel/server.py to:
How Has This Been Tested?
Breaking Changes
This is a breaking change that corrects the error handling behavior:
Types of changes
Checklist
Additional context