Skip to content

Commit a2072c3

Browse files
committed
Keep the stale-baseline guard fail-closed under pipefail
grep -q quitting at the first match SIGPIPEs the printf feeding it; with pipefail the pipeline reports 141 and the guard is skipped exactly when the pattern is present. A here-string has no writer to kill.
1 parent b4558ce commit a2072c3

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/actions/conformance/run-client.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ for scenario in "${scenarios[@]}"; do
4343
done
4444

4545
# A stale baseline entry is a configuration error a solo rerun cannot excuse.
46-
if printf '%s\n' "$plain" | grep -q '^Stale baseline entries'; then
46+
# Here-string, not a pipe: grep -q quitting early would SIGPIPE printf and,
47+
# under pipefail, skip this guard exactly when the pattern is present.
48+
if grep -q '^Stale baseline entries' <<<"$plain"; then
4749
echo "Suite also reported stale baseline entries; not retrying." >&2
4850
exit "$rc"
4951
fi

0 commit comments

Comments
 (0)