Skip to content

Commit b4558ce

Browse files
committed
Address review: drop stray fixture, gitignore results, single solo attempt
A solo failure on the quiet runner already disproves the contention hypothesis, so a second attempt was the blind retry the wrapper exists to avoid; CONFORMANCE_SOLO_ATTEMPTS remains the override.
1 parent 4eeca68 commit b4558ce

3 files changed

Lines changed: 6 additions & 13 deletions

File tree

.github/actions/conformance/run-client.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
set -uo pipefail
77

88
: "${CONFORMANCE_PKG:?set CONFORMANCE_PKG (pinned in .github/workflows/conformance.yml)}"
9-
SOLO_ATTEMPTS="${CONFORMANCE_SOLO_ATTEMPTS:-2}"
9+
# One attempt: a solo failure on the quiet runner disproves the contention
10+
# hypothesis; a second try would be the blind retry this script avoids.
11+
SOLO_ATTEMPTS="${CONFORMANCE_SOLO_ATTEMPTS:-1}"
1012

1113
# Relative args resolve from the repo root; same contract as run-server.sh.
1214
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,3 +173,6 @@ cython_debug/
173173

174174
# claude code
175175
results/
176+
177+
# conformance CI local runs
178+
conformance-results/

log.txt

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)