fix: reset SSE event type and id buffers after dispatch - #1094
Open
ez-lbz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the WHATWG SSE spec (§9.2.6), both the data buffer and the event type buffer must be reset when an event is dispatched. The SseLineSubscriber only reset the data buffer, so a prior named event (e.g.
event: ping) made every subsequent baredata:JSON-RPC message carry the stale event type. The client'sisMessageEventcheck then silently dropped those messages, leaving pending requests hanging.This change resets the event type and id buffers alongside the data buffer when an event is dispatched, and in hookOnComplete when a pending event is emitted.
Tests feed the subscriber a named event followed by a bare data event and assert the second event has no stale type or id.