mcp: return nil params for missing optional requests#1056
Open
ychampion wants to merge 2 commits into
Open
Conversation
Requests with missing optional params could store a typed nil pointer in the typed request. When middleware called GetParams, that pointer was returned as a non-nil Params interface, so standard nil checks did not protect later method calls. Normalize typed nil params in GetParams for client and server requests, and cover missing optional server params plus custom params that embed ParamsBase. Fixes modelcontextprotocol#1052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests with missing optional params could store a typed nil pointer in the typed request. Middleware calling GetParams then received a non-nil Params interface, so a normal nil check did not prevent calls like GetMeta from panicking.
This normalizes typed nil params in GetParams for both client and server requests, while leaving non-nil generated and custom params unchanged.
Fixes #1052
Tested: