Fix McpHeaderEncoder.DecodeValue throwing on the degenerate base64 wrapper - #1805
Open
latent-9 wants to merge 1 commit into
Open
Fix McpHeaderEncoder.DecodeValue throwing on the degenerate base64 wrapper#1805latent-9 wants to merge 1 commit into
latent-9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
McpHeaderEncoder.DecodeValuethrowsArgumentOutOfRangeExceptionon the input"=?base64?="instead of returning it unchanged, which contradicts its own contract ("returns the original value" when the value is not a valid base64 wrapper) and its never-throw test suite.The wrapper uses prefix
"=?base64?"(ends with?) and suffix"?="(starts with?), which overlap on the shared?. So"=?base64?="(length 10) satisfies bothStartsWith(prefix)andEndsWith(suffix). The inner length is then computed asLength - Prefix.Length - Suffix.Length=10 - 9 - 2=-1, andSubstring(9, -1)throws. Because thatSubstringis outside thetry, the exception propagates.This is reachable from a client-supplied header (for example
Mcp-Name: =?base64?=): every character is a valid header character, so it passes validation and reachesDecodeValue, turning an intended graceful rejection into an unhandled exception.Fix: guard the wrapper branch with a minimum-length check, so a value too short to hold any content falls through to the literal return (the same behavior as
DecodeValue_MissingSuffix_ReturnsLiteralValue). Added a regression test.