user: GetExecUser: always clone default Sgids#229
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GetExecUser to avoid sharing the defaults.Sgids backing array with the returned ExecUser, preventing accidental mutation of the defaults. It also simplifies initialization by guaranteeing a non-nil Sgids slice directly during struct construction.
Changes:
- Clone
defaults.Sgidswhen building the returnedExecUserto avoid slice aliasing. - Remove the post-initialization nil check by constructing
Sgidsas non-nil from the start.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Uid: defaults.Uid, | ||
| Gid: defaults.Gid, | ||
| Sgids: defaults.Sgids, | ||
| Sgids: append([]int{}, defaults.Sgids...), // Sgids slice *cannot* be nil. |
vvoland
approved these changes
Jun 30, 2026
Clone the default Sgids slice instead of sharing it to prevent accidentally mutating, and simplify the initialization by creating a non-nil copy directly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
user_deref_sgids
branch
from
09f4bb9 to
94f7eb4
Compare
Member
Author
|
rebased after #228 was merged; I'll merge once CI completes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone the default Sgids slice instead of sharing it to prevent accidentally mutating, and simplify the initialization by creating a non-nil copy directly.