WIP/PoC: Migrate Swarm integration off gogo/protobuf - #53288
Draft
vvoland wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
SwarmKit no longer generates messages with gogo/protobuf, so its message fields now use standard Go protobuf names, pointer semantics, and well-known types. Update the cluster, executor, event, and network allocator boundaries to use the standard protobuf runtime. Pass generated messages by pointer so their internal state is not copied, and preserve compatibility handling for older stored service and node fields. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
github-actions
Bot
added
area/networking
vvoland
marked this pull request as draft
August 3, 2026 11:00
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Every swarm update panicked before sending an HTTP response because the standard protobuf ClusterSpec uses pointers for nested messages, while the conversion code still treated them as always-present values. Initialize missing nested messages before merging the API spec. This restores the previous non-nullable protobuf behavior while preserving existing values during swarm initialization. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Use pointers for nested protobuf messages and adopt the generated standard protobuf field names so the Windows daemon test packages compile again. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consume swarmkit's migration from gogo/protobuf to the standard Go protobuf implementation.
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)