Cap terminal CSI cell operations - #1403
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
CSI ICH and DCH accept parameters up to 65535, but operations past the end of a row do not change the rendered terminal. A remote program that emits repeated sequences can keep mosh-server busy processing redundant vector changes. Limit both operations to the number of remaining columns. This preserves output while bounding work by terminal width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSI ICH and DCH accept counts up to 65535 and perform one vector operation
per requested cell. A remote program that displays attacker-controlled
terminal content can use repeated CSI sequences to keep mosh-server busy,
despite operations beyond the remaining columns having no visible effect.
Limit both operations to the remaining columns. This preserves rendering while
bounding work by terminal width.