groundwork for type-hinting mne/_fiff/* - #14152
Merged
Merged
Conversation
larsoner
approved these changes
Aug 12, 2026
larsoner
left a comment
larsoner
left a comment
Member
There was a problem hiding this comment.
Yep, there are going to be a few of these "split up a too-complicated function" things to fix along the way I think 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the
_safe_name_listhelper function into separate write and read flavors, reflecting previous disjoint logic branches based on paramoperation="read"|"write"This will simplify type-hinting of
mne/_fiff/*and since it's an easy to understand and isolatable change, it made sense to do it as a separate PR