Test for MNE-Tools actions - #13971
Conversation
|
Have now tested here all the actions implemented so far in mne-tools, save the old env checking. There are a couple differences between what happens currently and what the actions do, but only cosmetic, nothing that should affect the function. A summary of differences below: Syncing dependencies to env yaml
Citation generation
AFAIK, there isn't a way to get
Codemeta generation
|
|
Those whitespace changes would be okay but in its current form this is a bit tough to review since it just shows a |
|
pip-pre failure should be fixed in #14139 |
| command: | | ||
| set -x | ||
| ./tools/check_qt_import.sh ${MNE_QT_BACKEND} | ||
| curl https://raw.githubusercontent.com/mne-tools/mne-tools/main/tools/check_qt_import.sh -o check_qt_import.sh |
There was a problem hiding this comment.
CircleCI now uses two files from this repo (here and down in circleci_bash_env.sh). Better maybe to use a standard checkout step to a known directory and then use both from there?
There was a problem hiding this comment.
Originally I avoided relying on setup_xvfb.sh being already available for circleci_bash_env.sh, in case there were other packages using this which would need to be updated. However, I subsequently found that only MNE-Conn is using it: #13971 (comment)
There was a problem hiding this comment.
If we go back to circleci_bash_env.sh assuming setup_xvfb.sh is already present and the only downstream change would be in MNE-Conn, that's easy enough I guess. WDYT?
There was a problem hiding this comment.
@larsoner Would you prefer I remove the setup_xvfb.sh curl in circleci_bash_env.sh and fix downstream in MNE-Connecitivity, or can I leave this here?
Sure, happy with either order. Whichever is in a mergeable state first |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
Okay #14133 is in |
Added to the compound surnames in |
|
mne-tools/mne-tools#42 fixes the conda env availability for the |
Testing to get an idea of how the actions being implemented in MNE-Tools behave (mne-tools/mne-tools#20).