fix: Styled the sensor labels for topomap mask #13598
Open
+33
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13474
What does this implement/fix?
This PR introduces an initial styling change for masked sensor labels in topomap plots.
Masked labels now use a distinct visual style (bold) so they can be easily
distinguished from unmasked labels.
This follows the discussion suggesting that masked sensors should not look identical
to normal ones. A simple default style is implemented first, and additional styling
options (e.g. font properties dict) can be added in later PRs based on further
design discussion.
Additional information
At this stage, only minimal changes were made: the relevant text drawing
call applies a bold font weight when a sensor is masked.
This keeps the PR focused and beginner friendly. Future PRs may explore
exposing a
mask_label_styleparameter or creating mockups for alternativestyles as mentioned in the issue discussion.