test(benchmarks): populate orgname/systemname/mode/vdb_engine in VectorDB tests#556
Open
FileSystemGuy wants to merge 1 commit into
Open
test(benchmarks): populate orgname/systemname/mode/vdb_engine in VectorDB tests#556FileSystemGuy wants to merge 1 commit into
FileSystemGuy wants to merge 1 commit into
Conversation
…orDB tests Benchmark.__init__ now asserts that args.orgname is populated by the upstream orgname-resolution gate (base.py:125-133) and also reads args.mode, args.systemname, and (for vector_database) args.vdb_engine during _reserve_run_directory → generate_output_location. TestVectorDBBenchmark.test_constructor_accepts_kwargs and test_datasize_does_not_require_pymilvus built their SimpleNamespace without any of those, so each hit ConfigurationError before reaching the behaviors under test. Set realistic stand-in values on both Namespaces so the tests exercise the constructor-kwargs contract and the datasize dependency-skip contract that they were written to verify. The added fields mirror what the orgname/systemname plumbing populates in production.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`Benchmark.init` now asserts `args.orgname` is populated upstream by main._main_impl()'s orgname-resolution gate (base.py:125-133), and `_reserve_run_directory → generate_output_location` additionally reads `args.mode`, `args.systemname`, and (for vector_database) `args.vdb_engine`.
The two `TestVectorDBBenchmark` tests built their `SimpleNamespace` without any of those, so each tripped `ConfigurationError [E101]` before reaching the behaviors under test (`test_constructor_accepts_kwargs` verifies the constructor's run_datetime/logger kwarg contract; `test_datasize_does_not_require_pymilvus` verifies that datasize skips the pymilvus dep check).
Populate realistic stand-in values on both Namespaces so the tests actually exercise their intended contracts. The added fields mirror what the orgname/systemname plumbing populates in production.
Test plan