test(submission_checker): refresh MD5_EXCLUDE_PREFIXES exact-membership tuple#552
Merged
Conversation
…ip expected tuple constants.MD5_EXCLUDE_PREFIXES gained 8 new entries (.idea/, .vscode/, .claude/, .agent/, .agents/, .roo/, .planning/, .gsd-tmp/) to keep developer-tool / agent-runtime artifacts out of the code-tree MD5 (submission_checker/constants.py:163-182). The gate's test_md5_exclude_prefixes_exact_membership assertion still encoded the pre-change tuple and started failing as a result. Update the test's expected tuple to mirror the current production list verbatim. The "exact membership" gate is intentionally brittle — it's there to catch unintended drops as well as unintended additions — so the right fix is the maintenance step the constants-bumping commits should have taken, not loosening the gate to subset semantics. Added a one-line maintenance note on the test docstring so the next person who edits MD5_EXCLUDE_PREFIXES sees the contract.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`constants.MD5_EXCLUDE_PREFIXES` (`mlpstorage_py/submission_checker/constants.py:163-182`) gained 8 new entries — `.idea/`, `.vscode/`, `.claude/`, `.agent/`, `.agents/`, `.roo/`, `.planning/`, `.gsd-tmp/` — to keep developer-tool and agent-runtime artifacts out of the code-tree MD5. The `test_md5_exclude_prefixes_exact_membership` gate still encoded the pre-change tuple and started failing.
Update the expected tuple to mirror production. The "exact membership" gate is intentionally brittle — it's there to catch unintended drops as well as unintended additions — so the right fix is the maintenance step the constants-bumping commits should have taken, not loosening the gate to subset semantics. Also added a one-line maintenance note on the test docstring so the next person who edits the production constant sees the contract.
Test plan