test(vdb): declare 'test' optional-deps extra (psutil, h5py, pyyaml, mpi4py)#551
Merged
Conversation
…xtra test Two tests in vdb_benchmark/tests/ (test_compaction_with_resource_monitoring, test_memory_aware_loading) import psutil inside the test body and fail with ModuleNotFoundError when the vdb_benchmark venv doesn't have psutil installed. Several other tests likewise need pytest, pyyaml, h5py, or mpi4py at collection time. Declare these as a vdb_benchmark 'test' optional-dependency group so `uv run --extra test python -m pytest` self-contains every dep the vdb tests need. Brings the vdb sub-project in line with the main project's test-extra convention. After: full vdb test suite goes from 134/136 to 136/136 passing.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
idevasena
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
This is the first PR in a series of small, focused cleanups to bring the test suite to 0 failures + 0 unintentional skips.