chore(tests): restrict default pytest run to checkin tests; mark full suite invalid#37
Merged
Merged
Conversation
… suite invalid
The full test suite (dlio_dataset_dimension_test.py,
test_data_generator_improvements.py) tests aspirational/incorrect behaviour
and is expected to fail. Running it produces misleading failure reports and
takes hours.
Two-pronged fix:
1. pytest.ini: set testpaths = tests/test_fast_ci.py and
addopts = -m "not full_suite" so bare `pytest` only runs the ~85
fast checkin tests (< 10 min). Full suite must be invoked explicitly:
pytest tests/ -m full_suite
2. Mark both full-suite files with pytestmark = pytest.mark.full_suite
so the intent is visible in the files themselves and any pytest
invocation that does collect them skips them by default.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
FileSystemGuy
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The full test suite (
dlio_dataset_dimension_test.py,test_data_generator_improvements.py) tests aspirational/incorrect behaviour and is expected to fail. Runningpytest tests/produces misleading failure reports and takes hours.Two-pronged fix so this can never happen accidentally again:
Option 1 —
pytest.inidefault path:testpaths = tests/test_fast_ci.py— barepytestonly collects the ~85 fast checkin testsaddopts = -m "not full_suite"— even if someone runspytest tests/, full-suite files are excludedOption 2 — explicit marker in the files:
pytestmark = pytest.mark.full_suiteat module level, making the intent visible to anyone reading themTo run full suite explicitly (not recommended):
Test plan
pytest --collect-only -qcollects exactly 85 tests, all fromtest_fast_ci.pypytest -v(checkin suite) passes🤖 Generated with Claude Code