Find SwiftPM metallib bundle near test binary#3562
Open
RNT56 wants to merge 1 commit into
Open
Conversation
This was referenced May 19, 2026
RNT56
force-pushed
the
pr/swiftpm-metallib-bundle-lookup
branch
from
93232ea to
1a75e1a
Compare
Collaborator
|
Ping @davidkoski for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SwiftPM package/test layouts where
default.metallibis copied to the generatedSWIFTPM_BUNDLE.bundlenext to the test binary, but MLX only checks nested bundle locations.This keeps the existing lookup order and adds:
SWIFTPM_BUNDLE.bundlenext to the current binary, walking a few parent directoriesNSBundle.allBundles()already contains the SwiftPM resource bundleValidation
pre-commit run --all-filespassedmlx-swiftSwiftPM packaging branch:swift test --filter StreamTests/testDeviceTypepasses after applying this MLX loader patch and generatingdefault.metallibFailed to load the default metallib