Open
Conversation
zcbenz
force-pushed
the
encoder-refactor-3
branch
from
e732b85 to
2daec6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3078, #3216.
Refactor code to use
metal::get_command_encoderandCommandEncoderAPIs, instead of theDevicemethods likeDevice::get_command_encoder/add_temporarythat take stream index.The motivation is that,
Deviceare global objects that shared by all threads, but we do not want to shareCommandEncoderbetween threads, which does not have any performance benefit and brings various race conditions. This refactoring would allow us to storeCommandEncoderin thread-local storages and detect thread-safety issues caused by using streams from different threads.