Remove output pipe from sftp#60
Open
mkj wants to merge 5 commits into
Open
Conversation
Instead of writing to a pipe, the Write reference can be written directly. This avoids memcpy to/from the pipe. A couple of BUFFER_OUT_SIZE sized buffers are also removed, along with the Pipe instance. (BUFFER_OUT_SIZE = 512 bytes for the demo server) Mutable references are used for SftpOutputProducer now. This runs slightly slower than before, but seems worthwhile given the removed code and runtime memory saving. The performance could be investigated further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of writing to a pipe, the Write reference can be written directly. This avoids memcpy to/from the pipe.
A couple of BUFFER_OUT_SIZE sized buffers are also removed, along with the Pipe instance.
(BUFFER_OUT_SIZE = 512 bytes for the demo server)
This runs slightly slower than before, but seems worthwhile given the removed code and runtime memory saving.
The performance could be investigated further.