Remove impl Eq for Tree - #447
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the Eq implementation for Tree to avoid violating Eq’s reflexivity requirement when NaN values are present in tree constants or affine remaps.
Changes:
- Remove
impl Eq for Treefromfidget-core(keepingPartialEq). - Add a changelog entry documenting the removal and rationale.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
fidget-core/src/context/tree.rs |
Removes Eq impl to avoid incorrect Eq semantics in presence of NaN. |
CHANGELOG.md |
Notes the removal of Eq for Tree (but currently references a non-existent Tree::Const). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mkeeter
force-pushed
the
remove-tree-eq
branch
from
August 11, 2026 00:14
1bb3680 to
621f1a2
Compare
mkeeter
enabled auto-merge (squash)
August 11, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TreeOp::Const(f64::NAN)or aTreeOp::RemapAffinewithNaNvalues will break reflexivity.We're discussing workarounds in #446 , but this is trivially incorrect at the moment; management apologizes for the inconvenience.