Update dependency webpack-dev-middleware to v5 [SECURITY]#5373
Update dependency webpack-dev-middleware to v5 [SECURITY]#5373renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: yarn.lock |
398a6a5 to
1c3d0fb
Compare
1c3d0fb to
9d0c985
Compare
9d0c985 to
e2060f3
Compare
430c158 to
e8de645
Compare
eb4093c to
1198166
Compare
1198166 to
ca1f55a
Compare
ca1f55a to
4435207
Compare
|
4435207 to
62748b6
Compare
62748b6 to
40378cd
Compare
af90a40 to
6918d8d
Compare
2a6bf5a to
c5cc8bd
Compare
c5cc8bd to
332cf85
Compare
332cf85 to
83b453f
Compare
7b32b29 to
a30ff17
Compare
9121f54 to
ed52b70
Compare
ed52b70 to
8ac3761
Compare
8ac3761 to
8d10f27
Compare
8d10f27 to
dcc189e
Compare
| "webpack-bundle-tracker": "^0.4.3", | ||
| "webpack-cli": "^3.3.10", | ||
| "webpack-dev-middleware": "^1.9.0", | ||
| "webpack-dev-middleware": "^5.0.0", |
There was a problem hiding this comment.
Bug: Upgrading webpack-dev-middleware to v5 while using webpack v4 will cause a runtime error, as v5 requires webpack v5. This will break the development server.
Severity: CRITICAL
Suggested Fix
To resolve this incompatibility, either upgrade webpack to version 5.0.0 or higher to match the webpack-dev-middleware requirement, or find a version of webpack-dev-middleware that is compatible with webpack v4 and also contains the necessary security fix.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L132
Potential issue: The project upgrades `webpack-dev-middleware` to version `^5.0.0` but
continues to use `webpack` version `^4.46.0`. `webpack-dev-middleware` v5 has a peer
dependency on `webpack` v5 and is not backward compatible. When the development server
in `hot-reload-dev-server.js` initializes the middleware, it passes a `webpack` v4
compiler object. The middleware expects a `webpack` v5 compiler, and the mismatch in
APIs will cause a runtime error, preventing the development server from starting. This
will block all local development workflows.
Did we get this right? 👍 / 👎 to inform future reviews.
87a3c00 to
82ff367
Compare
| "webpack-bundle-tracker": "^0.4.3", | ||
| "webpack-cli": "^3.3.10", | ||
| "webpack-dev-middleware": "^1.9.0", | ||
| "webpack-dev-middleware": "^5.0.0", |
There was a problem hiding this comment.
Bug: The webpack-dev-middleware v5 upgrade is incompatible with the project's webpack v4 without manual configuration, which will cause the development server to crash on startup.
Severity: CRITICAL
Suggested Fix
To resolve the incompatibility, either upgrade webpack to v5, or manually configure the outputFileSystem for webpack-dev-middleware. If staying with webpack v4, you must provide an outputFileSystem instance that has the required .join() and mkdirp methods.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L132
Potential issue: The project's `webpack` version is `^4.46.0`, but
`webpack-dev-middleware` is being upgraded to v5. Version 5 of `webpack-dev-middleware`
is designed for `webpack` v5 and has breaking changes when used with `webpack` v4.
Specifically, it requires the `outputFileSystem` to have `.join()` and `mkdirp` methods,
which are not provided by default in the `webpack` v4 environment. Since the code does
not manually configure the `outputFileSystem`, the development server will fail to
start, preventing developers from running the application locally.
ee19901 to
fd92412
Compare
fd92412 to
cc23e9b
Compare
| "webpack-bundle-tracker": "^0.4.3", | ||
| "webpack-cli": "^3.3.10", | ||
| "webpack-dev-middleware": "^1.9.0", | ||
| "webpack-dev-middleware": "^5.0.0", |
There was a problem hiding this comment.
Bug: The upgrade of webpack-dev-middleware to v5 is incompatible with the project's existing webpack v4 dependency, which will break the development server.
Severity: CRITICAL
Suggested Fix
To resolve this incompatibility, either upgrade webpack to version 5 alongside the webpack-dev-middleware upgrade, or revert the webpack-dev-middleware upgrade to a version compatible with webpack v4.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L132
Potential issue: The pull request updates `webpack-dev-middleware` to version 5.0.0
while `webpack` remains at version 4.46.0. `webpack-dev-middleware` v5 has a peer
dependency requirement for `webpack` v5. The development server, initiated via
`hot-reload-dev-server.js`, passes a `webpack` v4 compiler instance to the
`webpack-dev-middleware`. This will cause a runtime crash during initialization because
the middleware will attempt to use webpack v5 APIs that do not exist in webpack v4,
breaking the local development workflow.
7d6d4d7 to
760c1e5
Compare
bb28f0d to
2a9d0e8
Compare
This PR contains the following updates:
^1.9.0→^5.0.0Path traversal in webpack-dev-middleware
CVE-2024-29180 / GHSA-wr3j-pwj9-hqq6
More information
Details
Summary
The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.
Details
The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21
The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.
PoC
A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwdImpact
The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).
If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).
If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.
Recommendation
The URL should be unescaped and normalized before any further processing.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:N/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Path traversal in webpack-dev-middleware
CVE-2024-29180 / GHSA-wr3j-pwj9-hqq6
More information
Details
Summary
The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.
Details
The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21
The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.
PoC
A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwdImpact
The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).
If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).
If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.
Recommendation
The URL should be unescaped and normalized before any further processing.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:N/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
webpack/webpack-dev-middleware (webpack-dev-middleware)
v5.3.4Compare Source
5.3.4 (2024-03-20)
Bug Fixes
v5.3.3Compare Source
⚠ BREAKING CHANGES
5.3.3 (2022-05-18)
Bug Fixes
RequestandResponse(#1271) (eeb8aa8)5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes
v5.3.2Compare Source
⚠ BREAKING CHANGES
5.3.3 (2022-05-18)
Bug Fixes
RequestandResponse(#1271) (eeb8aa8)5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes
v5.3.1Compare Source
⚠ BREAKING CHANGES
5.3.3 (2022-05-18)
Bug Fixes
RequestandResponse(#1271) (eeb8aa8)5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes
v5.3.0Compare Source
⚠ BREAKING CHANGES
5.3.3 (2022-05-18)
Bug Fixes
RequestandResponse(#1271) (eeb8aa8)5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes
v5.2.2Compare Source
Features
5.2.2 (2021-11-17)
Chore
schema-utilspackage to4.0.0version5.2.1 (2021-09-25)
v5.2.1Compare Source
Features
5.2.2 (2021-11-17)
Chore
schema-utilspackage to4.0.0version5.2.1 (2021-09-25)
v5.2.0Compare Source
Features
5.2.2 (2021-11-17)
Chore
schema-utilspackage to4.0.0version5.2.1 (2021-09-25)
v5.1.0Compare Source
Features
Rangeheader is present (e8b21f0)Bug Fixes
mempackage (#1027) (0d55268)v5.0.0Compare Source
⚠ BREAKING CHANGES
Node.jsversion is12.13.0(#928) (4cffeff)v4.3.0Compare Source
Features
getFilenameFromUrlto API (#911) (1edc726)Bug Fixes
v4.2.0Compare Source
Features
headersoption to accept function (#897) (966afb3)v4.1.0Compare Source
Features
statsoption (376cdba)4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
statstostdoutinsteadstderr, how doeswebpack-cli, if you need hidestatsfrom output please use{ stats: false }or{ stats: 'none' }(4de0f97)stats(4de0f97)Content-type headeron unknown types (#809) (5c9eee5)4.0.2 (2020-11-10)
Bug Fixes
headersoption (#763) (7c4cac5)4.0.1 (2020-11-09)
Bug Fixes
connect(b83a1db)v4.0.4Compare Source
Features
statsoption (376cdba)4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
statstostdoutinsteadstderr, how doeswebpack-cli, if you need hidestatsfrom output please use{ stats: false }or{ stats: 'none' }(4de0f97)stats(4de0f97)Content-type headeron unknown types (#809) (5c9eee5)4.0.2 (2020-11-10)
Bug Fixes
headersoption (#763) (7c4cac5)4.0.1 (2020-11-09)
Bug Fixes
connect(b83a1db)v4.0.3Compare Source
Features
statsoption (376cdba)4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
statstostdoutinsteadstderr, how doeswebpack-cli, if you need hidestatsfrom output please use{ stats: false }or{ stats: 'none' }(4de0f97)stats(4de0f97)Content-type headeron unknown types (#809) (5c9eee5)4.0.2 (2020-11-10)
Bug Fixes
headersoption (#763) (7c4cac5)4.0.1 (2020-11-09)
Bug Fixes
connect(b83a1db)v4.0.2Compare Source
Features
statsoption (376cdba)4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
statstostdoutinsteadstderr, how doeswebpack-cli, if you need hidestatsfrom output please use{ stats: false }or{ stats: 'none' }(4de0f97)stats(4de0f97)Content-type headeron unknown types (#809) (5c9eee5)4.0.2 (2020-11-10)
Bug Fixes
headersoption (#763) (7c4cac5)4.0.1 (2020-11-09)
Bug Fixes
connect(b83a1db)v4.0.1Compare Source
Features
statsoption (376cdba)4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
statstostdoutinsteadstderr, how doeswebpack-cli, if you need hidestatsfrom output please use{ stats: false }or{ stats: 'none' }(4de0f97)stats(4de0f97)Content-type headeron unknown types (#809) (5c9eee5)4.0.2 (2020-11-10)
Bug Fixes
headersoption (#763) (7c4cac5)4.0.1 (2020-11-09)
Bug Fixes
connect(b83a1db)v4.0.0Compare Source
Features
statsoption (376cdba)4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
statstostdoutinsteadstderr, how doeswebpack-cli, if you need hidestatsfrom output please use{ stats: false }or{ stats: 'none' }(4de0f97)stats(4de0f97)Content-type headeron unknown types (#809) (5c9eee5)4.0.2 (2020-11-10)
Bug Fixes
headersoption (#763) (7c4cac5)4.0.1 (2020-11-09)
Bug Fixes
connect(b83a1db)v3.7.3Compare Source
3.7.3 (2020-12-15)
Bug Fixes
v3.7.2Compare Source
Bug Fixes
options.jsonfile (#589) (41d6264)4.0.0-rc.0 (2020-02-19)
Bug Fixes
output.pathandoutput.publicPathoptions from the configurationstatsoption from the configurationwatchOptionsoption from the configurationwriteToDiskoption now correctly works in multi-compiler modeoutputFileSystemoption now correctly works in multi-compiler mode[hash]/[fullhash]inoutput.pathandoutput.publicPathContent-Typeheader doesn't havecharset=utf-8value for custom MIME types and MIME types which can be nonutf-8Features
webpackloggermemfspackageBREAKING CHANGES
10.13.0publicPathis taken from the value of theoutput.publicPathoption from the configuration (webpack.config.js)statsoption was removed, the default value of thestatsoption is taken from the value of thestatsoption from the configuration (webpack.config.js)watchOptionswas removed, the default value of thewatchOptionsoption is taken from the value of thewatchOptionsoption from the configuration (webpack.config.js)Content-Typeheader doesn't havecharset=utf-8value for custom MIME types and MIME types which can be nonutf-8fsoption was renamed to theoutputFileSystemoptionlazyoption was removed without replacementlogger,logLevelandlogTimeoptions were removed without replacement. You can setup thelevelvalue using{ infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use theinfrastructurelog(infrastructureLoginwebpack@5) hook to customize logs. Thelogproperty in the middleware context was renamed tologgermimeTypesoption first requires you to specify an extension and then a content-type -{ mimeTypes: { phtml: 'text/html' } }forceoption from themimeTypesoption was removed without replacementreporteroption was removed without replacementgetFilenameFromUrlmethod was removed from the APIlocalsnow underres.locals.webpack- useres.locals.webpack.statsfor accessstatsandres.locals.webpack.outputFileSystemto accessoutputFileSystem3.7.2 (2019-09-28)
Bug Fixes
writeToDiskused (#472) (6730076)3.7.1 (2019-09-03)
Bug Fixes
writeToFileoption has compatibility with webpack@5 (#459) (5c90e1e)v3.7.1Compare Source
Bug Fixes
options.jsonfile (#589) (41d6264)4.0.0-rc.0 (2020-02-19)
Bug Fixes
output.pathandoutput.publicPathoptions from the configurationstatsoption from the configurationwatchOptionsoption from the configurationwriteToDiskoption now correctly works in multi-compiler modeoutputFileSystemoption now correctly works in multi-compiler mode[hash]/[fullhash]inoutput.pathandoutput.publicPathContent-Typeheader doesn't havecharset=utf-8value for custom MIME types and MIME types which can be nonutf-8Features
webpackloggermemfspackageBREAKING CHANGES
10.13.0publicPathis taken from the value of theoutput.publicPathoption from the configuration (webpack.config.js)statsoption was removed, the default value of thestatsoption is taken from the value of thestatsoption from the configuration (webpack.config.js)watchOptionswas removed, the default value of thewatchOptionsoption is taken from the value of thewatchOptionsoption from the configuration (webpack.config.js)Content-Typeheader doesn't havecharset=utf-8value for custom MIME types and MIME types which can be nonutf-8fsoption was renamed to theoutputFileSystemoptionlazyoption was removed without replacementlogger,logLevelandlogTimeoptions were removed without replacement. You can setup thelevelvalue using{ infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use theinfrastructurelog(infrastructureLoginwebpack@5) hook to customize logs. Thelogproperty in the middleware context was renamed tologgermimeTypesoption first requires you to specify an extension and then a content-type -{ mimeTypes: { phtml: 'text/html' } }forceoption from themimeTypesoption was removed without replacementreporteroption was removed without replacementgetFilenameFromUrlmethod was removed from the APIlocalsnow underres.locals.webpack- useres.locals.webpack.statsfor accessstatsandres.locals.webpack.outputFileSystemto accessoutputFileSystem3.7.2 (2019-09-28)
Bug Fixes
writeToDiskused (#472) (6730076)3.7.1 (2019-09-03)
Bug Fixes
writeToFileoption has compatibility with webpack@5 (#459) (5c90e1e)v3.7.0Compare Source
Bug Fixes
options.jsonfile (#589) (41d6264)4.0.0-rc.0 (2020-02-19)
Bug Fixes
output.pathandoutput.publicPathoptions from the configurationstatsoption from the configurationwatchOptionsoption from the configurationwriteToDiskoption now correctly works in multi-compiler modeoutputFileSystemoption now correctly works in multi-compiler mode[hash]/[fullhash]inoutput.pathandoutput.publicPathContent-Typeheader doesn't havecharset=utf-8value for custom MIME types and MIME types which can be nonutf-8Features
webpackloggermemfspackageBREAKING CHANGES
10.13.0publicPathis taken from the value of theoutput.publicPathoption from the configuration (webpack.config.js)statsoption was removed, the default value of thestatsoption is taken from the value of thestatsoption from the configuration (webpack.config.js)watchOptionswas removed, the default value of thewatchOptionsoption is taken from the value of thewatchOptionsoption from the configuration (webpack.config.js)Content-Typeheader doesn't havecharset=utf-8value for custom MIME types and MIME types which can be nonutf-8fsoption was renamed to theoutputFileSystemoptionlazyoption was removed without replacementlogger,logLevelandlogTimeoptions were removed without replacement. You can setup thelevelvalue using{ infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use theinfrastructurelog(infrastructureLoginwebpack@5) hook to customize logs. Thelogproperty in the middleware context was renamed tologgermimeTypesoption first requires you to specify an extension and then a content-type -{ mimeTypes: { phtml: 'text/html' } }forceoption from themimeTypesoption was removed without replacementreporteroption was removed without replacementgetFilenameFromUrlmethod was removed from the APIlocalsnow underres.locals.webpack- useres.locals.webpack.statsfor accessstatsandres.locals.webpack.outputFileSystemto accessoutputFileSystem3.7.2 (2019-09-28)
Bug Fixes
writeToDiskused (#472) (6730076)3.7.1 (2019-09-03)
Bug Fixes
writeToFileoption has compatibility with webpack@5 (#459) (5c90e1e)v3.6.2Compare Source
Bug Fixes
res.getHeaderand set the correct Content-Type (#385) (56dc705)v3.6.1Compare Source
Bug Fixes
v3.6.0Compare Source
Features
v3.5.2Compare Source
Bug Fixes
usdzfile type (#357) (b135b3d)v3.5.1Compare Source
Bug Fixes
v3.5.0Compare Source
Bug Fixes
Features
mimeTypes(possible to useforceoption) (#349) (e56a181)v3.4.0Compare Source
Bug FixesunhandledRejection(#340) (f0a8e3e)url-joinwithpath.posix.join(#334) (d75802b)v3.3.0Compare Source
Features
response.locals.fs) (#337) (f9a138e)v3.2.0Compare Source
Bug Fixes
Features
methodsoption (options.methods) (#319) (fe6bb86)[
v3.1.3](https://redirect.githuConfiguration
📅 Schedule: (in timezone US/Eastern)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.