Skip to content

Update dependency webpack-dev-middleware to v5 [SECURITY]#5373

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-webpack-dev-middleware-vulnerability
Open

Update dependency webpack-dev-middleware to v5 [SECURITY]#5373
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-webpack-dev-middleware-vulnerability

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Mar 22, 2024

ℹ️ Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
webpack-dev-middleware ^1.9.0^5.0.0 age confidence

Path traversal in webpack-dev-middleware

CVE-2024-29180 / GHSA-wr3j-pwj9-hqq6

More information

Details

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin
Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

Severity

  • CVSS Score: 7.4 / 10 (High)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:N/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Path traversal in webpack-dev-middleware

CVE-2024-29180 / GHSA-wr3j-pwj9-hqq6

More information

Details

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin
Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

Severity

  • CVSS Score: 7.4 / 10 (High)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:N/A:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware)

v5.3.4

Compare Source

5.3.4 (2024-03-20)
Bug Fixes

v5.3.3

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.3.2

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.3.1

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.3.0

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.2.2

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.2.1

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.2.0

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.1.0

Compare Source

Features
  • don't read full file if Range header is present (e8b21f0)
  • output more information on errors (#​1024) (7df9e44)
Bug Fixes

v5.0.0

Compare Source

⚠ BREAKING CHANGES

v4.3.0

Compare Source

Features
Bug Fixes

v4.2.0

Compare Source

Features

v4.1.0

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.4

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.3

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.2

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.1

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.0

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v3.7.3

Compare Source

3.7.3 (2020-12-15)
Bug Fixes

v3.7.2

Compare Source

Bug Fixes
4.0.0-rc.0 (2020-02-19)
Bug Fixes
  • respect output.path and output.publicPath options from the configuration
  • respect the stats option from the configuration
  • respect the watchOptions option from the configuration
  • the writeToDisk option now correctly works in multi-compiler mode
  • the outputFileSystem option now correctly works in multi-compiler mode
  • respect [hash]/[fullhash] in output.path and output.publicPath
  • handle exceptions for filesystem operations
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
Features
  • validate options
  • migrate on the webpack logger
  • migrate on the memfs package
  • improve performance
BREAKING CHANGES
  • minimum supported Node.js version is 10.13.0
  • the default value of the option publicPath is taken from the value of the output.publicPath option from the configuration (webpack.config.js)
  • the stats option was removed, the default value of the stats option is taken from the value of the stats option from the configuration (webpack.config.js)
  • the watchOptions was removed, the default value of the watchOptions option is taken from the value of the watchOptions option from the configuration (webpack.config.js)
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
  • the fs option was renamed to the outputFileSystem option
  • the lazy option was removed without replacement
  • the logger, logLevel and logTime options were removed without replacement. You can setup the level value using { infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use the infrastructurelog (infrastructureLog in webpack@5) hook to customize logs. The log property in the middleware context was renamed to logger
  • the mimeTypes option first requires you to specify an extension and then a content-type - { mimeTypes: { phtml: 'text/html' } }
  • the force option from the mimeTypes option was removed without replacement
  • the reporter option was removed without replacement
  • the getFilenameFromUrl method was removed from the API
  • the middleware locals now under res.locals.webpack - use res.locals.webpack.stats for access stats and res.locals.webpack.outputFileSystem to access outputFileSystem
3.7.2 (2019-09-28)
Bug Fixes
3.7.1 (2019-09-03)
Bug Fixes

v3.7.1

Compare Source

Bug Fixes
4.0.0-rc.0 (2020-02-19)
Bug Fixes
  • respect output.path and output.publicPath options from the configuration
  • respect the stats option from the configuration
  • respect the watchOptions option from the configuration
  • the writeToDisk option now correctly works in multi-compiler mode
  • the outputFileSystem option now correctly works in multi-compiler mode
  • respect [hash]/[fullhash] in output.path and output.publicPath
  • handle exceptions for filesystem operations
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
Features
  • validate options
  • migrate on the webpack logger
  • migrate on the memfs package
  • improve performance
BREAKING CHANGES
  • minimum supported Node.js version is 10.13.0
  • the default value of the option publicPath is taken from the value of the output.publicPath option from the configuration (webpack.config.js)
  • the stats option was removed, the default value of the stats option is taken from the value of the stats option from the configuration (webpack.config.js)
  • the watchOptions was removed, the default value of the watchOptions option is taken from the value of the watchOptions option from the configuration (webpack.config.js)
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
  • the fs option was renamed to the outputFileSystem option
  • the lazy option was removed without replacement
  • the logger, logLevel and logTime options were removed without replacement. You can setup the level value using { infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use the infrastructurelog (infrastructureLog in webpack@5) hook to customize logs. The log property in the middleware context was renamed to logger
  • the mimeTypes option first requires you to specify an extension and then a content-type - { mimeTypes: { phtml: 'text/html' } }
  • the force option from the mimeTypes option was removed without replacement
  • the reporter option was removed without replacement
  • the getFilenameFromUrl method was removed from the API
  • the middleware locals now under res.locals.webpack - use res.locals.webpack.stats for access stats and res.locals.webpack.outputFileSystem to access outputFileSystem
3.7.2 (2019-09-28)
Bug Fixes
3.7.1 (2019-09-03)
Bug Fixes

v3.7.0

Compare Source

Bug Fixes
4.0.0-rc.0 (2020-02-19)
Bug Fixes
  • respect output.path and output.publicPath options from the configuration
  • respect the stats option from the configuration
  • respect the watchOptions option from the configuration
  • the writeToDisk option now correctly works in multi-compiler mode
  • the outputFileSystem option now correctly works in multi-compiler mode
  • respect [hash]/[fullhash] in output.path and output.publicPath
  • handle exceptions for filesystem operations
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
Features
  • validate options
  • migrate on the webpack logger
  • migrate on the memfs package
  • improve performance
BREAKING CHANGES
  • minimum supported Node.js version is 10.13.0
  • the default value of the option publicPath is taken from the value of the output.publicPath option from the configuration (webpack.config.js)
  • the stats option was removed, the default value of the stats option is taken from the value of the stats option from the configuration (webpack.config.js)
  • the watchOptions was removed, the default value of the watchOptions option is taken from the value of the watchOptions option from the configuration (webpack.config.js)
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
  • the fs option was renamed to the outputFileSystem option
  • the lazy option was removed without replacement
  • the logger, logLevel and logTime options were removed without replacement. You can setup the level value using { infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use the infrastructurelog (infrastructureLog in webpack@5) hook to customize logs. The log property in the middleware context was renamed to logger
  • the mimeTypes option first requires you to specify an extension and then a content-type - { mimeTypes: { phtml: 'text/html' } }
  • the force option from the mimeTypes option was removed without replacement
  • the reporter option was removed without replacement
  • the getFilenameFromUrl method was removed from the API
  • the middleware locals now under res.locals.webpack - use res.locals.webpack.stats for access stats and res.locals.webpack.outputFileSystem to access outputFileSystem
3.7.2 (2019-09-28)
Bug Fixes
3.7.1 (2019-09-03)
Bug Fixes

v3.6.2

Compare Source

Bug Fixes
  • check existence of res.getHeader and set the correct Content-Type (#​385) (56dc705)

v3.6.1

Compare Source

Bug Fixes
  • do not overwrite Content-Type if header already exists (#​377) (b2a6fed)

v3.6.0

Compare Source

Features

v3.5.2

Compare Source

Bug Fixes

v3.5.1

Compare Source

Bug Fixes
  • remove querystring from filenames when writing to disk (#​361) (90d0d94)

v3.5.0

Compare Source

Bug Fixes
Features
  • allow to redefine mimeTypes (possible to use force option) (#​349) (e56a181)

v3.4.0

Compare Source

Bug Fixes
  • index: don't modify the default behavior for unhandledRejection (#​340) (f0a8e3e)
  • middleware: replace url-join with path.posix.join (#​334) (d75802b)

v3.3.0

Compare Source

Features
  • middleware: expose the memory filesystem (response.locals.fs) (#​337) (f9a138e)

v3.2.0

Compare Source

Bug Fixes
Features
  • middleware: add methods option (options.methods) (#​319) (fe6bb86)

[v3.1.3](https://redirect.githu


Configuration

📅 Schedule: (in timezone US/Eastern)

  • Branch creation
    • ""
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
Copy link
Copy Markdown
Contributor Author

renovate Bot commented Mar 22, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.28.0/14.18.2/node_modules/corepack/dist/yarn.js:2
process.env.COREPACK_ENABLE_DOWNLOAD_PROMPT??='1'
                                           ^^^

SyntaxError: Unexpected token '??='
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47

@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 398a6a5 to 1c3d0fb Compare March 26, 2024 12:44
@renovate renovate Bot changed the title Update dependency webpack-dev-middleware to v5 [SECURITY] fix(deps): update dependency webpack-dev-middleware to v5 [security] Mar 26, 2024
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 1c3d0fb to 9d0c985 Compare March 26, 2024 14:38
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 9d0c985 to e2060f3 Compare April 2, 2024 15:06
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 2 times, most recently from 430c158 to e8de645 Compare April 17, 2024 12:04
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 4 times, most recently from eb4093c to 1198166 Compare April 25, 2024 18:08
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 1198166 to ca1f55a Compare May 3, 2024 15:47
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from ca1f55a to 4435207 Compare May 20, 2024 18:27
@renovate
Copy link
Copy Markdown
Contributor Author

renovate Bot commented May 20, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.34.6/14.18.2/node_modules/corepack/dist/yarn.js:2
process.env.COREPACK_ENABLE_DOWNLOAD_PROMPT??='1'
                                           ^^^

SyntaxError: Unexpected token '??='
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47

@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 4435207 to 62748b6 Compare May 20, 2024 19:54
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 62748b6 to 40378cd Compare May 28, 2024 20:07
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 2 times, most recently from af90a40 to 6918d8d Compare June 17, 2024 15:12
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 3 times, most recently from 2a6bf5a to c5cc8bd Compare October 7, 2024 19:20
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from c5cc8bd to 332cf85 Compare October 17, 2024 14:06
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 332cf85 to 83b453f Compare October 25, 2024 12:22
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 3 times, most recently from 7b32b29 to a30ff17 Compare November 25, 2024 15:54
@renovate renovate Bot changed the title fix(deps): update dependency webpack-dev-middleware to v5 [security] fix(deps): update dependency webpack-dev-middleware to v5 [security] - autoclosed Dec 8, 2024
@renovate renovate Bot closed this Dec 8, 2024
@renovate renovate Bot deleted the renovate/npm-webpack-dev-middleware-vulnerability branch December 8, 2024 18:53
@renovate renovate Bot changed the title fix(deps): update dependency webpack-dev-middleware to v5 [security] - autoclosed fix(deps): update dependency webpack-dev-middleware to v5 [security] Dec 8, 2024
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 3 times, most recently from 9121f54 to ed52b70 Compare January 21, 2026 14:31
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from ed52b70 to 8ac3761 Compare January 23, 2026 11:51
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 8ac3761 to 8d10f27 Compare February 3, 2026 15:03
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 8d10f27 to dcc189e Compare February 24, 2026 05:05
Comment thread package.json
"webpack-bundle-tracker": "^0.4.3",
"webpack-cli": "^3.3.10",
"webpack-dev-middleware": "^1.9.0",
"webpack-dev-middleware": "^5.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading webpack-dev-middleware to v5 while using webpack v4 will cause a runtime error, as v5 requires webpack v5. This will break the development server.
Severity: CRITICAL

Suggested Fix

To resolve this incompatibility, either upgrade webpack to version 5.0.0 or higher to match the webpack-dev-middleware requirement, or find a version of webpack-dev-middleware that is compatible with webpack v4 and also contains the necessary security fix.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L132

Potential issue: The project upgrades `webpack-dev-middleware` to version `^5.0.0` but
continues to use `webpack` version `^4.46.0`. `webpack-dev-middleware` v5 has a peer
dependency on `webpack` v5 and is not backward compatible. When the development server
in `hot-reload-dev-server.js` initializes the middleware, it passes a `webpack` v4
compiler object. The middleware expects a `webpack` v5 compiler, and the mismatch in
APIs will cause a runtime error, preventing the development server from starting. This
will block all local development workflows.

Did we get this right? 👍 / 👎 to inform future reviews.

@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 8 times, most recently from 87a3c00 to 82ff367 Compare March 1, 2026 02:09
Comment thread package.json
"webpack-bundle-tracker": "^0.4.3",
"webpack-cli": "^3.3.10",
"webpack-dev-middleware": "^1.9.0",
"webpack-dev-middleware": "^5.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The webpack-dev-middleware v5 upgrade is incompatible with the project's webpack v4 without manual configuration, which will cause the development server to crash on startup.
Severity: CRITICAL

Suggested Fix

To resolve the incompatibility, either upgrade webpack to v5, or manually configure the outputFileSystem for webpack-dev-middleware. If staying with webpack v4, you must provide an outputFileSystem instance that has the required .join() and mkdirp methods.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L132

Potential issue: The project's `webpack` version is `^4.46.0`, but
`webpack-dev-middleware` is being upgraded to v5. Version 5 of `webpack-dev-middleware`
is designed for `webpack` v5 and has breaking changes when used with `webpack` v4.
Specifically, it requires the `outputFileSystem` to have `.join()` and `mkdirp` methods,
which are not provided by default in the `webpack` v4 environment. Since the code does
not manually configure the `outputFileSystem`, the development server will fail to
start, preventing developers from running the application locally.

@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 5 times, most recently from ee19901 to fd92412 Compare March 5, 2026 19:40
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from fd92412 to cc23e9b Compare March 9, 2026 15:04
Comment thread package.json
"webpack-bundle-tracker": "^0.4.3",
"webpack-cli": "^3.3.10",
"webpack-dev-middleware": "^1.9.0",
"webpack-dev-middleware": "^5.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade of webpack-dev-middleware to v5 is incompatible with the project's existing webpack v4 dependency, which will break the development server.
Severity: CRITICAL

Suggested Fix

To resolve this incompatibility, either upgrade webpack to version 5 alongside the webpack-dev-middleware upgrade, or revert the webpack-dev-middleware upgrade to a version compatible with webpack v4.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L132

Potential issue: The pull request updates `webpack-dev-middleware` to version 5.0.0
while `webpack` remains at version 4.46.0. `webpack-dev-middleware` v5 has a peer
dependency requirement for `webpack` v5. The development server, initiated via
`hot-reload-dev-server.js`, passes a `webpack` v4 compiler instance to the
`webpack-dev-middleware`. This will cause a runtime crash during initialization because
the middleware will attempt to use webpack v5 APIs that do not exist in webpack v4,
breaking the local development workflow.

@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 3 times, most recently from 7d6d4d7 to 760c1e5 Compare March 19, 2026 19:14
@renovate renovate Bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 2 times, most recently from bb28f0d to 2a9d0e8 Compare March 26, 2026 14:13
@renovate renovate Bot changed the title fix(deps): update dependency webpack-dev-middleware to v5 [security] fix(deps): update dependency webpack-dev-middleware to v5 [security] - autoclosed Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants