feat: Table tagging related changes#236
Conversation
📝 WalkthroughWalkthroughThis PR extends MinIO S3 Tables IAM policy support by introducing dedicated warehouse and table tagging operations. New condition keys are registered, action constants replace resource-level tagging with warehouse/table-specific variants, and the condition-key mapping logic is refactored to use helper closures that automatically include tag keys for relevant actions. ChangesS3 Tables Warehouse and Table Tagging Policy Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@policy/table-action.go`:
- Around line 211-223: Restore the legacy exported constants
(S3TablesTagResourceAction, S3TablesUntagResourceAction,
S3TablesListTagsForResourceAction) as deprecated aliases that map to the new
names (e.g. S3TablesTagResourceAction = S3TablesTagTableAction or appropriate
mapping), and ensure those legacy strings are included in SupportedTableActions
so ValidateTable continues to accept existing persisted policies; also add the
same deprecated aliases for the warehouse variants referenced around the later
block (the other set at lines ~288-293) so both table and warehouse legacy
symbols remain exported for v3 compatibility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 21ed3803-0e80-4a62-8414-fca4a6ed88cb
📒 Files selected for processing (2)
policy/condition/keyname.gopolicy/table-action.go
WarehouseTagandTableTagcondition keysTagResourceAction, untag, and list withTagTableActionandTagWarehouseActionSee https://github.com/miniohq/aistor/pull/5687
Summary by CodeRabbit
New Features
Chores