feat: add GetAllGlobalCertificates to expose the global cert cache#234
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new exported helper in the certs package to enumerate the globally cached TLS certificates (registered via GetClientCertificate() / GetCertificate()), and updates several module dependencies as part of the Go module state.
Changes:
- Add
certs.GetAllGlobalCertificates()to return all leaf certificates currently registered in the global cert cache. - Update
golang.org/x/*andgithub.com/go-jose/go-jose/v4dependency versions ingo.mod/go.sum.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
certs/global_certs.go |
Introduces GetAllGlobalCertificates() for enumerating certificates stored in the global cache. |
go.mod |
Bumps several direct/indirect dependencies (notably x/crypto, x/sys, x/net, x/text, x/tools, x/mod, go-jose). |
go.sum |
Updates checksums corresponding to the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harshavardhana
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a package-level function that returns the leaf x509 certificate
for every cert pair registered in the global cache via
GetClientCertificate()orGetCertificate().Needed for https://github.com/miniohq/eos/pull/5418