Skip to content

feat: add GetAllGlobalCertificates to expose the global cert cache#234

Merged
harshavardhana merged 5 commits into
minio:mainfrom
JoelRuizRojas:get-all-certs
Jun 3, 2026
Merged

feat: add GetAllGlobalCertificates to expose the global cert cache#234
harshavardhana merged 5 commits into
minio:mainfrom
JoelRuizRojas:get-all-certs

Conversation

@JoelRuizRojas

@JoelRuizRojas JoelRuizRojas commented May 29, 2026

Copy link
Copy Markdown
Contributor

Add a package-level function that returns the leaf x509 certificate
for every cert pair registered in the global cache via
GetClientCertificate() or GetCertificate().

Needed for https://github.com/miniohq/eos/pull/5418

@JoelRuizRojas JoelRuizRojas self-assigned this May 29, 2026
@JoelRuizRojas JoelRuizRojas added the enhancement New feature or request label May 29, 2026
@JoelRuizRojas JoelRuizRojas marked this pull request as ready for review June 2, 2026 03:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new exported helper in the certs package to enumerate the globally cached TLS certificates (registered via GetClientCertificate() / GetCertificate()), and updates several module dependencies as part of the Go module state.

Changes:

  • Add certs.GetAllGlobalCertificates() to return all leaf certificates currently registered in the global cert cache.
  • Update golang.org/x/* and github.com/go-jose/go-jose/v4 dependency versions in go.mod / go.sum.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
certs/global_certs.go Introduces GetAllGlobalCertificates() for enumerating certificates stored in the global cache.
go.mod Bumps several direct/indirect dependencies (notably x/crypto, x/sys, x/net, x/text, x/tools, x/mod, go-jose).
go.sum Updates checksums corresponding to the dependency bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread certs/global_certs.go Outdated
Comment thread certs/global_certs.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comment thread certs/certs_test.go
Comment thread certs/certs_test.go
@JoelRuizRojas JoelRuizRojas requested a review from reivaj05 June 3, 2026 14:50
@harshavardhana harshavardhana merged commit 384ec9e into minio:main Jun 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants