Minor project cleanup by removing unused packages and files#988
Merged
michelebastione merged 5 commits intoJul 22, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBenchmark fixture paths now use the ChangesFixture and test cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@benchmarks/MiniExcel.Benchmarks/BenchmarkBase.cs`:
- Line 5: Make the benchmark fixture paths portable by replacing Windows-style
backslashes with forward slashes or Path.Combine in BenchmarkBase.FilePath and
both fixture path usages in TemplateExcelBenchmark at lines 40 and 59; preserve
the existing relative locations and filenames.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: db0cda7f-b9ad-42dc-a37b-0d6bfd11e35c
⛔ Files ignored due to path filters (9)
benchmarks/MiniExcel.Benchmarks/Test1,000,000x10.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/Test1,000,000x10_SharingStrings.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/data/Test10,000x10.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/data/Test100,000x10.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/data/Test100x10.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/data/Test10x10.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/data/TestTemplateBasicIEmumerableFill.xlsxis excluded by!**/*.xlsxbenchmarks/MiniExcel.Benchmarks/data/TestTemplateBasicIEmumerableFill_ClosedXML_Report.xlsxis excluded by!**/*.xlsxtests/data/csv/TestLargeFile_1,000,000.csvis excluded by!**/*.csv
📒 Files selected for processing (9)
.gitattributesbenchmarks/MiniExcel.Benchmarks/BenchmarkBase.csbenchmarks/MiniExcel.Benchmarks/BenchmarkSections/CreateExcelBenchmark.csbenchmarks/MiniExcel.Benchmarks/BenchmarkSections/TemplateExcelBenchmark.csbenchmarks/MiniExcel.Benchmarks/MiniExcel.Benchmarks.csprojtests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterAsyncTests.cstests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterTests.cstests/MiniExcel.OpenXml.Tests/Main/Models.cstests/MiniExcel.OpenXml.Tests/MiniExcel.OpenXml.Tests.csproj
💤 Files with no reviewable changes (4)
- tests/MiniExcel.OpenXml.Tests/MiniExcel.OpenXml.Tests.csproj
- tests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterAsyncTests.cs
- tests/MiniExcel.OpenXml.Tests/Main/Models.cs
- tests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterTests.cs
michelebastione
force-pushed
the
minor-cleanup
branch
from
July 22, 2026 21:39
93b35f9 to
bd7a5b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following small changes:
Summary by CodeRabbit
Summary by CodeRabbit
Tests
Benchmarks
data/directory.Chores
.slnxfiles and test fixture diffs.