Skip to content

Minor project cleanup by removing unused packages and files#988

Merged
michelebastione merged 5 commits into
mini-software:masterfrom
michelebastione:minor-cleanup
Jul 22, 2026
Merged

Minor project cleanup by removing unused packages and files#988
michelebastione merged 5 commits into
mini-software:masterfrom
michelebastione:minor-cleanup

Conversation

@michelebastione

@michelebastione michelebastione commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

This PR includes the following small changes:

  • Removed unused System.Security.Cryptography.Xml package
  • Removed some tests of questionable usefulness
  • Refactored benchmarks sample data
  • Updated .gitattribtues to treat all tests data files as binary data

Summary by CodeRabbit

Summary by CodeRabbit

  • Tests

    • Removed several large-file performance/memory and shared-string caching tests.
    • Removed an unused test model.
  • Benchmarks

    • Updated benchmark input/template paths to consistently use the data/ directory.
    • Adjusted benchmark fixture copying/output handling to match the new paths.
  • Chores

    • Updated repository file handling rules for .slnx files and test fixture diffs.
    • Removed an unused test-project dependency.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22cda8eb-ce04-46ad-a7dd-ccfd94049d79

📥 Commits

Reviewing files that changed from the base of the PR and between 93b35f9 and bd7a5b0.

📒 Files selected for processing (2)
  • benchmarks/MiniExcel.Benchmarks/BenchmarkBase.cs
  • benchmarks/MiniExcel.Benchmarks/BenchmarkSections/TemplateExcelBenchmark.cs
🚧 Files skipped from review as they are similar to previous changes (1)
  • benchmarks/MiniExcel.Benchmarks/BenchmarkBase.cs

📝 Walkthrough

Walkthrough

Benchmark fixture paths now use the data directory, repository attributes classify solution and test-data files, and obsolete large-file tests, a test model, and a package reference were removed.

Changes

Fixture and test cleanup

Layer / File(s) Summary
Repository fixture attributes
.gitattributes
.slnx files use text handling with union merges, while tests/data/** is marked binary.
Benchmark data paths
benchmarks/MiniExcel.Benchmarks/...
Benchmark inputs and templates now reference files under data/; one unchanged OpenXML expression was reformatted.
Test suite cleanup
tests/MiniExcel.OpenXml.Tests/...
Large-file and shared-string tests, the DemoPocoHelloWorld model, and the System.Security.Cryptography.Xml package reference were removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main cleanup theme and accurately reflects the removal of unused packages and files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@benchmarks/MiniExcel.Benchmarks/BenchmarkBase.cs`:
- Line 5: Make the benchmark fixture paths portable by replacing Windows-style
backslashes with forward slashes or Path.Combine in BenchmarkBase.FilePath and
both fixture path usages in TemplateExcelBenchmark at lines 40 and 59; preserve
the existing relative locations and filenames.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db0cda7f-b9ad-42dc-a37b-0d6bfd11e35c

📥 Commits

Reviewing files that changed from the base of the PR and between 3c6fd59 and dc8538a.

⛔ Files ignored due to path filters (9)
  • benchmarks/MiniExcel.Benchmarks/Test1,000,000x10.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/Test1,000,000x10_SharingStrings.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/data/Test10,000x10.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/data/Test100,000x10.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/data/Test100x10.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/data/Test10x10.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/data/TestTemplateBasicIEmumerableFill.xlsx is excluded by !**/*.xlsx
  • benchmarks/MiniExcel.Benchmarks/data/TestTemplateBasicIEmumerableFill_ClosedXML_Report.xlsx is excluded by !**/*.xlsx
  • tests/data/csv/TestLargeFile_1,000,000.csv is excluded by !**/*.csv
📒 Files selected for processing (9)
  • .gitattributes
  • benchmarks/MiniExcel.Benchmarks/BenchmarkBase.cs
  • benchmarks/MiniExcel.Benchmarks/BenchmarkSections/CreateExcelBenchmark.cs
  • benchmarks/MiniExcel.Benchmarks/BenchmarkSections/TemplateExcelBenchmark.cs
  • benchmarks/MiniExcel.Benchmarks/MiniExcel.Benchmarks.csproj
  • tests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterAsyncTests.cs
  • tests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterTests.cs
  • tests/MiniExcel.OpenXml.Tests/Main/Models.cs
  • tests/MiniExcel.OpenXml.Tests/MiniExcel.OpenXml.Tests.csproj
💤 Files with no reviewable changes (4)
  • tests/MiniExcel.OpenXml.Tests/MiniExcel.OpenXml.Tests.csproj
  • tests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterAsyncTests.cs
  • tests/MiniExcel.OpenXml.Tests/Main/Models.cs
  • tests/MiniExcel.OpenXml.Tests/Main/MiniExcelOpenXmlImporterTests.cs

Comment thread benchmarks/MiniExcel.Benchmarks/BenchmarkBase.cs Outdated
@michelebastione
michelebastione merged commit d5abe04 into mini-software:master Jul 22, 2026
4 checks passed
@michelebastione
michelebastione deleted the minor-cleanup branch July 22, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant