Skip to content

Some basic refactoring and improvements#5

Open
fentonscode wants to merge 1 commit intomingdeyu:dev1from
fentonscode:updates
Open

Some basic refactoring and improvements#5
fentonscode wants to merge 1 commit intomingdeyu:dev1from
fentonscode:updates

Conversation

@fentonscode
Copy link
Copy Markdown
Contributor

Some quick changes as below:

  • PEP formatting and static checks
  • Type hints
  • Redundant or improper comparisons
  • Redundant deepcopy call (carefully checked, there's a few mode to remove)
  • Some faster pure Python code in places
  • Some major speedups in the jit functions (still a few to go in the Matern code too)

K2=np.zeros((n,n))
if name == 'sexp':
X_l = X / length
# ~50% faster by avoiding expand_dims
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have said "100%", same effect below in the other jit functions

@mingdeyu mingdeyu changed the base branch from master to dev1 October 16, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant