-
Notifications
You must be signed in to change notification settings - Fork 0
add build-push-deploy #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamishfagg
wants to merge
27
commits into
main
Choose a base branch
from
add/build-push-deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8f30a64
initial
hamishfagg 63df8dd
fix
hamishfagg b0f0f27
fix
hamishfagg d2736ba
fix
hamishfagg 10bfe9b
fix
hamishfagg d89cc67
fix
hamishfagg 7ae5c59
fix
hamishfagg 8facb60
fix
hamishfagg 458c9f0
fix
hamishfagg bfd5d44
fix
hamishfagg 7e9a827
fix
hamishfagg 8e45f86
fix
hamishfagg f97bb17
fix
hamishfagg b5a22fd
fix
hamishfagg b855cba
fix
hamishfagg f20315e
fix
hamishfagg 318229d
fix
hamishfagg c58b909
fix
hamishfagg e0786b1
fix
hamishfagg dc832e8
fix
hamishfagg 7eb5d87
WIP
hamishfagg 2769466
add bake
hamishfagg 0594a3a
add deploy namespace
hamishfagg 5aef156
add migration
hamishfagg c7fd0f7
secret->var
hamishfagg 3b20427
log into ecr
hamishfagg 833709f
fix migrate
hamishfagg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| service-name: | ||
| description: "Name of the service to build. Used as the default image name and src dir unless 'image-name' or 'src-path' are used." | ||
| type: string | ||
| required: true | ||
| stage-name: | ||
| description: "The backend environment we are building for (API calls are pointed to). This should be one of (development, staging, production)." | ||
| type: string | ||
| required: true | ||
| deploy-namespace: | ||
| description: "The Kubernetes namespace to deploy the service to." | ||
| type: string | ||
| required: false | ||
| docker-build-args: | ||
| description: "Extra args passed to 'docker build'." | ||
| type: string | ||
| required: false | ||
| docker-image-ref: | ||
| description: "The version number or sha used in creating image tag." | ||
| type: string | ||
| required: false | ||
| default: "${{ github.sha }}" | ||
| dockerfiles: | ||
| description: "JSON list of dockerfiles to build, e.g. ['Dockerfile1', 'Dockerfile2']" | ||
| type: string | ||
| required: false | ||
| default: "['Dockerfile']" | ||
| docker-bake-target: | ||
| description: "The target to build with docker bake." | ||
| type: string | ||
| required: false | ||
| docker-bake-platforms: | ||
| description: "The platforms to build with docker bake." | ||
| type: string | ||
| required: false | ||
|
|
||
|
|
||
| jobs: | ||
| # Looks for PR labels like "deploy-to-<env>" so we can deploy to those envs | ||
| get-deploy-labels: | ||
| name: Get Deploy Envs | ||
| runs-on: mdb-dev | ||
| concurrency: | ||
| group: ${{ github.workflow_ref }} # workflow_ref contains the workflow name and branch ref | ||
| cancel-in-progress: true # Cancel any in-progress runs on this branch - this one is newer | ||
| outputs: | ||
| deploy-envs: ${{ steps.get-labels.outputs.deploy-envs }} | ||
| steps: | ||
| - id: get-labels | ||
| uses: mindsdb/github-actions/get-deploy-labels@main | ||
|
|
||
|
|
||
| # Build docker image(s) based on Dockerfile(s) and push to ECR | ||
| build: | ||
| runs-on: mdb-dev | ||
| needs: [get-deploy-labels] | ||
| if: ${{ !inputs.docker-bake && needs.get-deploy-labels.outputs.deploy-envs != '[]' }} | ||
| strategy: | ||
| matrix: | ||
| dockerfile: ${{fromJson(inputs.dockerfiles)}} | ||
| concurrency: | ||
| group: ${{ github.workflow_ref }} # workflow_ref contains the workflow name and branch ref | ||
| cancel-in-progress: true # Cancel any in-progress runs on this branch - this one is newer | ||
| env: | ||
| AWS_REGION: us-east-1 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ inputs.docker-image-ref }} | ||
| # Build via docker-bake if a bakefile is specified | ||
| - if: ${{ contains(matrix.dockerfile, '.hcl') }} | ||
| uses: mindsdb/github-actions/docker-bake@main | ||
| with: | ||
| git-sha: ${{ inputs.docker-image-ref }} | ||
| target: ${{ inputs.docker-bake-target }} | ||
| platforms: ${{ inputs.docker-bake-platforms }} | ||
| push-cache: false | ||
| # Otherwise build via regular docker | ||
| - if: ${{ !contains(matrix.dockerfile, '.hcl') }} | ||
| uses: mindsdb/github-actions/build-push-ecr@main | ||
| with: | ||
| module-name: ${{ inputs.service-name }} | ||
| build-for-environment: ${{ inputs.stage-name }} | ||
| extra-build-args: "-f ${{ matrix.dockerfile }}" | ||
|
|
||
|
|
||
| # Deploy the built image to the specified environments | ||
| # Deploys to all environments at once | ||
| deploy: | ||
| runs-on: mdb-dev | ||
| needs: [ get-deploy-labels, build ] | ||
| strategy: | ||
| matrix: | ||
| deploy-env: ${{fromJson(needs.get-deploy-labels.outputs.deploy-envs)}} | ||
| concurrency: | ||
| group: deploy-${{ matrix.deploy-env }} # All deployments for this env are grouped together | ||
| cancel-in-progress: false # Don't cancel in-progress deployments, it breaks helm | ||
| environment: | ||
| # Assuming that ENV_URL is set in a github environment in the repo | ||
| # If not the link in the slack message will be borked, thats all | ||
| name: ${{ matrix.deploy-env }} | ||
| url: ${{ vars.ENV_URL }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mindsdb/github-actions/setup-env@main | ||
| - name: Notify of deployment starting | ||
| # This same message will be updated later with the deployment status | ||
| id: slack | ||
| uses: mindsdb/github-actions/slack-deploy-msg@main | ||
| with: | ||
| channel-id: ${{ secrets.SLACK_DEPLOYMENTS_CHANNEL_ID }} | ||
| status: "started" | ||
| color: "#0099CC" | ||
| env-name: ${{ matrix.deploy-env }} | ||
| env-url: ${{ vars.ENV_URL }} | ||
| slack-token: ${{ secrets.GH_ACTIONS_SLACK_BOT_TOKEN }} | ||
| - uses: DevOps-Nirvana/aws-helm-multi-deploy-nodocker@v4 | ||
| # Do the actual deployment | ||
| with: | ||
| environment-slug: ${{matrix.deploy-env}} | ||
| k8s-namespace: ${{inputs.deploy-namespace || matrix.deploy-env}} | ||
| image-tag: ${{ inputs.stage-name }}-${{ github.sha }} | ||
|
hamishfagg marked this conversation as resolved.
|
||
| timeout: 600s | ||
| # We need to wait till deployment is finished here, since the calling workflow might test the deployment env once this job is done | ||
| wait: "true" | ||
| - name: Notify of deployment finish | ||
| # Update the slack message from before with the deployment status | ||
| uses: mindsdb/github-actions/slack-deploy-msg@main | ||
| if: always() | ||
| with: | ||
| channel-id: ${{ secrets.SLACK_DEPLOYMENTS_CHANNEL_ID }} | ||
| status: "${{ job.status == 'success' && 'finished' || 'failed' }}" | ||
| color: "${{ job.status == 'success' && '#00C851' || '#FF4444' }}" | ||
| env-name: ${{ matrix.deploy-env }} | ||
| env-url: ${{ vars.ENV_URL }} | ||
| slack-token: ${{ secrets.GH_ACTIONS_SLACK_BOT_TOKEN }} | ||
| update-message-id: ${{ steps.slack.outputs.ts }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness:
k8s-namespaceassignment uses${{inputs.deploy-namespace || matrix.deploy-env}}, but GitHub Actions expressions do not support||for defaulting, causing the value to be set to the literal string or empty ifdeploy-namespaceis not provided, resulting in deployments to the wrong namespace or failure.🤖 AI Agent Prompt for Cursor/Windsurf
📝 Committable Code Suggestion