Fix Columnar sort priority crash after mutation#274
Open
GabrielNagy wants to merge 1 commit intomime-types:mainfrom
Open
Fix Columnar sort priority crash after mutation#274GabrielNagy wants to merge 1 commit intomime-types:mainfrom
GabrielNagy wants to merge 1 commit intomime-types:mainfrom
Conversation
When a setter like extensions= clears @__sort_priority and the container is not fully loaded, Columnar#update_sort_priority reads bits from nil instead of recomputing. Fall back to super in that case. Signed-off-by: Gabriel Nagy <gabrielnagy@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a setter like
extensions=clears@__sort_priorityand the container is not fully loaded,Columnar#update_sort_priorityreads bits from nil instead of recomputing. Fall back to super in that case.Short repro script: