Allow deploy-card to show message provided in options#316
Closed
terrymun wants to merge 2 commits intomikesprague:mainfrom
Closed
Allow deploy-card to show message provided in options#316terrymun wants to merge 2 commits intomikesprague:mainfrom
message provided in options#316terrymun wants to merge 2 commits intomikesprague:mainfrom
Conversation
Owner
|
Thank you for the PR! And sorry for the (extended) delay in getting back to you and looking at it. I have finally gotten around to modernizing this codebase some and implementing a couple things - this has included setting up unit tests with 100% coverage as well as the feature in your PR. This is now available in Thanks again for the submission! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mikesprague! Thanks for this amazing package. I was consuming it and realized that the
deploy-cardandmessageoptions are mutually exclusive: ifdeploy-card: trueis used, then themessageprovided will not be rendered in the card at all.This pull request allows
messageto be added to the deploy-card.