Body text goes missing when using add_file#1539
Open
balvig wants to merge 1 commit intomikel:masterfrom
Open
Conversation
This was referenced Dec 13, 2022
balvig
added a commit
to ActiveCampaign/postmark-gem
that referenced
this pull request
Dec 13, 2022
## What Locks the `mail` dependency to `~> 2.7.0` ## Why `v 2.8.0` of the mail gem is causing [tests to fail](https://app.circleci.com/pipelines/github/ActiveCampaign/postmark-gem/115/workflows/98f981da-bff4-4abb-b0ad-eaeb8045e873). Currently investigating here mikel/mail#1539, but since it's just a development dependency we can lock the version to the CI back to green for now.
Contributor
|
It’s rather odd that the truffleruby head build succeeded. |
balvig
added a commit
to ActiveCampaign/postmark-gem
that referenced
this pull request
Oct 11, 2023
## What Alternate workaround to #135 and #143. ## Why While there still seems to be an [issue with `add_mail` "clearing" `body`,](mikel/mail#1539) instead of locking the gem for all ruby version and making it difficult to test newer ones, we can limit the version restrictions to legacy version and use this workaround of flipping the order for Ruby 2.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a failing test so far, as I'm not sure if this is actually a problem or I'm just doing something wrong! 🙇
It seems that since
v 2.8, usingadd_filecauses the body text to go missing:Am happy to try and fleshing this out to a fix, but wanted to first double check whether this is indeed expected behavior of not.
The behavior does not seem to occur in
2.7.