Skip to content

ci: test against Node 20 - #1768

Open
dinwwwh wants to merge 1 commit into
middleapi:mainfrom
dinwwwh:ci/test-against-node-20
Open

ci: test against Node 20#1768
dinwwwh wants to merge 1 commit into
middleapi:mainfrom
dinwwwh:ci/test-against-node-20

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Aug 3, 2026

Copy link
Copy Markdown
Member
  • Add Node 20 to the CI test matrix
  • Fall back to ws WebSocket in crossws tests since Node 20 lacks a global WebSocket
  • Upgrade pnpm to 12.0.0-beta.3

- Add Node 20 to the CI test matrix
- Fall back to `ws` WebSocket in crossws tests since Node 20 lacks a
  global WebSocket
- Upgrade pnpm to 12.0.0-beta.3
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
orpc Error Error Aug 3, 2026 7:38am

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one note on the pnpm beta.

Reviewed changes

  • Node 20 added to CI matrix — one-line addition in .github/workflows/ci.yaml.
  • pnpm upgraded to 12.0.0-beta.3packageManager field in root package.json; lockfile regenerated.
  • WebSocket fallback for crossws tests — the two crossws test helpers now import ws as a fallback constructor since Node 20 has no global WebSocket.

The typeof WebSocket !== 'undefined' guard is correct — it avoids the ReferenceError that would occur from referencing an undeclared global directly.

The pnpm beta upgrade affects all workflows (CI, release, codspeed, sponsor sync) since they all use pnpm/action-setup@v6 without a pinned version, which delegates to corepack. If you'd prefer to limit the beta exposure, you could pin pnpm/action-setup@v6 with version: 12 in the release workflow while keeping packageManager at a stable release. That's a judgement call — nothing blocking here.

Pullfrog  | Fix it ➔View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant