Skip to content

test(cloudflare): increase sleep duration for cleanup in durable publisher object tests#1632

Merged
dinwwwh merged 1 commit into
middleapi:mainfrom
dinwwwh:test/cloudflare/fix-time-assert
Jul 6, 2026
Merged

test(cloudflare): increase sleep duration for cleanup in durable publisher object tests#1632
dinwwwh merged 1 commit into
middleapi:mainfrom
dinwwwh:test/cloudflare/fix-time-assert

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Jul 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
orpc Skipped Skipped Jul 6, 2026 7:26am

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — test-only adjustment that increases cleanup wait times in the Durable Publisher Object replay tests to avoid timing-boundary flakiness.

  • Changed two await sleep(500) calls to await sleep(1_500) in packages/cloudflare/src/publisher-object.test.ts, with comments explaining the extra margin past the 3,000ms cleanup throttle window.
  • Updated the drops old replay messages on publish assertion from toHaveLength(3) to toHaveLength(2) since the longer wait causes event 2 to also exceed the 3-second replay retention window and be dropped alongside event 1.

Pullfrog  | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Jul 6, 2026

Copy link
Copy Markdown
More templates

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@1632

@orpc/bun

npm i https://pkg.pr.new/@orpc/bun@1632

@orpc/client

npm i https://pkg.pr.new/@orpc/client@1632

@orpc/cloudflare

npm i https://pkg.pr.new/@orpc/cloudflare@1632

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@1632

@orpc/experimental-effect

npm i https://pkg.pr.new/@orpc/experimental-effect@1632

@orpc/evlog

npm i https://pkg.pr.new/@orpc/evlog@1632

@orpc/interop

npm i https://pkg.pr.new/@orpc/interop@1632

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@1632

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@1632

@orpc/next

npm i https://pkg.pr.new/@orpc/next@1632

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@1632

@orpc/opentelemetry

npm i https://pkg.pr.new/@orpc/opentelemetry@1632

@orpc/pino

npm i https://pkg.pr.new/@orpc/pino@1632

@orpc/publisher

npm i https://pkg.pr.new/@orpc/publisher@1632

@orpc/ratelimit

npm i https://pkg.pr.new/@orpc/ratelimit@1632

@orpc/server

npm i https://pkg.pr.new/@orpc/server@1632

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@1632

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@1632

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@1632

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@1632

commit: e342c76

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dinwwwh dinwwwh merged commit 8f2cd62 into middleapi:main Jul 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant