Add persistent input validation logging (Microsoft.Security.SystemsADM.10031)#1604
Open
KenitoInc wants to merge 1 commit into
Open
Add persistent input validation logging (Microsoft.Security.SystemsADM.10031)#1604KenitoInc wants to merge 1 commit into
KenitoInc wants to merge 1 commit into
Conversation
…M.10031) Implements Write-EntraInputValidationLog function to persistently log all user input that fails validation, satisfying security requirement Microsoft.Security.SystemsADM.10031 from threat model review. Changes: - Add Write-EntraInputValidationLog.ps1 to each submodule folder that performs input validation (Applications, CertificateBasedAuthentication, DirectoryManagement, SignIns, Users, Governance) - Integrate logging calls into all 23 cmdlets with validation failure paths - Logs written to %LOCALAPPDATA%\Microsoft.Entra\Logs\ (file-based, no admin) - Attempts Windows Event Log (Application, EventId 1001) as secondary store - Sensitive values automatically masked in log output - Non-blocking: logging failures never interrupt cmdlet execution - Add unit tests (15 tests) and integration tests (8 tests) - all passing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Learn Build status updates of commit e4d0bd2: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds persistent logging of input validation failures to satisfy compliance requirement.
Problem
Validation failures were only displayed to the user via Write-Warning/Write-Error/throw without being persisted for security audit purposes.
Solution
Created
Write-EntraInputValidationLogfunction that:%LOCALAPPDATA%/Microsoft.Entra/Logs/InputValidation-{date}.logloggercommandChanges
Write-EntraInputValidationLog.ps1in each submodule folder (5 Entra + 4 EntraBeta)Cross-platform
[System.Environment]::UserNameon non-Windows (instead of WindowsIdentity)[Environment]::GetFolderPath('LocalApplicationData')(works on all platforms)Testing