Skip to content

Network - 26881 - Default Ruleset is enabled in Application Gateway WAF#1005

Merged
merill merged 5 commits intodevfrom
Feature-26881
Mar 13, 2026
Merged

Network - 26881 - Default Ruleset is enabled in Application Gateway WAF#1005
merill merged 5 commits intodevfrom
Feature-26881

Conversation

@praneeth-0000
Copy link
Copy Markdown
Collaborator

@praneeth-0000 praneeth-0000 self-assigned this Mar 6, 2026
@praneeth-0000 praneeth-0000 added the enhancement New feature or request label Mar 6, 2026
@peresys13 peresys13 requested a review from Copilot March 6, 2026 04:47
@praneeth-0000 praneeth-0000 marked this pull request as draft March 6, 2026 04:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Azure Network Security assessment (Test ID 26881) to evaluate whether Application Gateway WAF policies have an active default managed ruleset, and provides the accompanying markdown content used in reporting.

Changes:

  • Introduces Test-Assessment.26881.ps1 to query Application Gateway WAF policies via Azure Resource Graph and generate a compliance report.
  • Adds Test-Assessment.26881.md to provide the test’s descriptive and remediation content for the final report.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/powershell/tests/Test-Assessment.26881.ps1 New assessment logic + ARG query + markdown report generation for default ruleset enablement on App Gateway WAF policies
src/powershell/tests/Test-Assessment.26881.md New test description/remediation markdown consumed by Add-ZtTestResultDetail

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/powershell/tests/Test-Assessment.26881.ps1 Outdated
Comment thread src/powershell/tests/Test-Assessment.26881.ps1 Outdated
@praneeth-0000 praneeth-0000 marked this pull request as ready for review March 10, 2026 04:32
@praneeth-0000 praneeth-0000 added the ready for review PR is ready for review and merging label Mar 10, 2026
Copy link
Copy Markdown
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praneeth-0000 Please, address my feedback.

Comment thread src/powershell/tests/Test-Assessment.26881.ps1 Outdated
Copy link
Copy Markdown
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praneeth-0000 Please, address my feedback.

Comment thread src/powershell/tests/Test-Assessment.26881.ps1
Comment thread src/powershell/tests/Test-Assessment.26881.ps1 Outdated
Copy link
Copy Markdown
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merill merill merged commit 7df6cc0 into dev Mar 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready for review PR is ready for review and merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants