Skip to content

Restrict artifact temp directory permissions on Unix#15729

Open
nohwnd wants to merge 5 commits intomicrosoft:mainfrom
nohwnd:secure-artifact-temp-dir
Open

Restrict artifact temp directory permissions on Unix#15729
nohwnd wants to merge 5 commits intomicrosoft:mainfrom
nohwnd:secure-artifact-temp-dir

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Apr 28, 2026

Set 0700 on the artifact processing directory on non-Windows so it is only accessible by the creating user.

Implicitly tested by DotnetSDKSimulation_PostProcessing which does a full collect + post-process round-trip through the real temp path.

Copilot AI review requested due to automatic review settings April 28, 2026 14:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restricts permissions on the artifact-processing temp directory on Unix so artifacts are only accessible by the creating user.

Changes:

  • Create the correlationId parent artifact directory before writing artifacts.
  • Add Unix-only permission hardening (0700) for that directory via chmod (no-op on Windows / .NET Framework).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nohwnd nohwnd force-pushed the secure-artifact-temp-dir branch from 4fc1c73 to 942ed8a Compare April 28, 2026 14:50
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 29, 2026 07:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

nohwnd and others added 2 commits April 29, 2026 11:50
…ectory

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 29, 2026 13:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants