Skip to content

Remove deprecated WebTest and TMI test methods#15525

Merged
nohwnd merged 5 commits intomicrosoft:mainfrom
nohwnd:fix/15489-do-todos
Mar 23, 2026
Merged

Remove deprecated WebTest and TMI test methods#15525
nohwnd merged 5 commits intomicrosoft:mainfrom
nohwnd:fix/15489-do-todos

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Mar 19, 2026

Remove tests that were already [Ignore]d and marked with TODOs for removal:

  • WebTestRunAllTestsWithRunSettings - deprecated web test framework, already ignored
  • CodedWebTestRunAllTests - deprecated web test framework, already ignored
  • DiscoverTmiTestsWithOnlyPropertyValue - TMI no longer supported, already ignored

These tests were permanently disabled and explicitly tagged for removal.

Fixes #15489

Remove tests that were already [Ignore]d and marked with TODOs for
removal:
- WebTestRunAllTestsWithRunSettings (deprecated web test framework)
- CodedWebTestRunAllTests (deprecated web test framework)
- DiscoverTmiTestsWithOnlyPropertyValue (TMI no longer supported)

Fixes microsoft#15489

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 19, 2026 17:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes acceptance/integration tests that were permanently ignored and explicitly marked for deletion due to deprecated/unsupported legacy frameworks (WebTest and TMI).

Changes:

  • Deleted the ignored TMI discovery test from TestCaseFilterTests.cs.
  • Deleted the ignored WebTest/CodedWebTest execution tests from DifferentTestFrameworkSimpleTests.cs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestCaseFilterTests.cs Removes ignored TMI-based discovery test that targets an unsupported adapter/workflow.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/DifferentTestFrameworkSimpleTests.cs Removes ignored WebTest/CodedWebTest tests tied to deprecated web test framework/assets.

The System.IO using became unnecessary after removing the TMI test
method which was the only consumer of Path.Combine/GetDirectoryName.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Mar 20, 2026

needs removal of the projects as well, assigned

No code references this package after removing the WebTest tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 20, 2026 08:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes permanently ignored/deprecated acceptance tests related to legacy WebTest and TMI adapters, along with the now-unneeded QTools assets dependency.

Changes:

  • Deleted ignored TMI discovery test from TestCaseFilterTests.cs.
  • Deleted ignored WebTest/CodedWebTest execution tests from DifferentTestFrameworkSimpleTests.cs.
  • Removed Microsoft.TestPlatform.QTools.Assets package reference from the acceptance test project.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestCaseFilterTests.cs Removes the deprecated/ignored TMI filter discovery test and related System.IO usage.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Microsoft.TestPlatform.Acceptance.IntegrationTests.csproj Drops the QTools assets package reference now that WebTest assets aren’t used.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/DifferentTestFrameworkSimpleTests.cs Removes deprecated/ignored WebTest and CodedWebTest acceptance tests.

nohwnd and others added 2 commits March 20, 2026 11:05
Remove 4 [Ignore]d tests waiting for 'new host with CUIT removed'.
CUIT (Coded UI Test) was deprecated and removed from Visual Studio
years ago. These tests will never be un-ignored:
- LegacySettingsWithScripts
- LegacySettingsWithDeploymentItem
- LegacySettingsTestTimeout
- LegacySettingsAssemblyResolution

The LegacySettingsUnitTestProject asset is kept as it is still used
by the live LegacySettingsWithPlatform test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove LegacySettingsWithPlatform (live), RunTestsWithTestSettingsInTpv2
and RunTestsWithTestSettingsInTpv0 (both [Ignore]d). Testsettings and
TPv0 are deprecated and removed.

Delete the LegacySettingsUnitTestProject test asset from disk and
solution as it has no remaining consumers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nohwnd nohwnd added the 🚢 Ship it! Add to PRs where owner approves automated PR, but cannot approve because they "wrote it". label Mar 20, 2026
@nohwnd nohwnd enabled auto-merge (squash) March 20, 2026 18:26
@nohwnd nohwnd merged commit 234cdf3 into microsoft:main Mar 23, 2026
6 checks passed
nohwnd added a commit to nohwnd/vstest that referenced this pull request Mar 24, 2026
…s' into fix-mstest-analyzers

Resolve merge conflicts by keeping upstream removal of deprecated WebTest
and TMI test methods (removed in microsoft#15525), while preserving all of Amaury's
MSTest analyzer fixes in the remaining files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢 Ship it! Add to PRs where owner approves automated PR, but cannot approve because they "wrote it".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

do the todos

3 participants