chore: bump @github/copilot-sdk to 1.0.7-preview.3#326106
Closed
vs-code-engineering[bot] wants to merge 2 commits into
Closed
chore: bump @github/copilot-sdk to 1.0.7-preview.3#326106vs-code-engineering[bot] wants to merge 2 commits into
vs-code-engineering[bot] wants to merge 2 commits into
Conversation
vs-code-engineering
Bot
added
the
copilot-sdk-auto-upgrade
Contributor
Author
|
🏗️ Product build queued for cycle 1: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=456293 — validating the PR branch… |
Contributor
Author
|
❌ Product build against the PR branch — cycle 1:
|
koffi 3.x (pulled in transitively by @github/copilot-sdk 1.0.7-preview.3) delivers its native addon via per-platform @koromix/koffi-<platform> optional packages. Add packaging handling that keeps only the build target's koffi package and materializes it for cross-builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Commit pushed:
|
Contributor
Author
|
🏗️ Product build queued for cycle 2: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=456297 — validating the PR branch… |
Contributor
Author
|
❌ Product build against the PR branch — cycle 2:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated bump of
@github/copilot-sdkto the latest signed version.@github/copilot-sdk:^1.0.7-preview.0→^1.0.7-preview.3@github/copilot:^1.0.70-0→^1.0.71-2main@53e335d0387969ba6b6bd68f2481be89252089caDraft until validation passes. The
sdk-vscode-bump-fixagent will prime packaging changes from the canary insights and iterate on failures.Each product build triggered for this PR is posted as a comment below with a link.
🤖 SDK bump fix status — cycle 1
Validating:
@github/copilot-sdk@1.0.7-preview.3·@github/copilot@1.0.71-2· basemainProduct-build state: cycle 1 build (ADO
456293) failed. Fix pushed — build will be re-dispatched automatically (→ cycle 2).What changed this cycle
build/lib/copilot.ts— newgetKoffiExcludeFilter+ensureKoffiPlatformPackagehelpers (mirroring the existing ripgrep/copilot platform handling).build/gulpfile.vscode.ts/build/gulpfile.reh.ts— wired the ensure call + exclude filter into app and REH packaging.build/lib/test/copilot.test.ts— coverage for the new koffi filter.Why (root cause)
This bump pulls in
koffi@3.1.1transitively via@github/copilot-sdk(new — koffi was absent onmain). koffi 3.x ships its native addon through per-platform@koromix/koffi-<platform>optional packages (15 of them: darwin/linux/win32 + freebsd/openbsd/ia32/loong64/riscv64). There was no packaging handling for these, so:koffi.nodefiles would ship and break per-platform codesign (win32 signs all*.node) / bloat the payload.The fix keeps only the build target's
@koromix/koffi-<platform>(materializing it from the lockfile when npm didn't install it) and strips the rest.SDK + CLI correlation
The Slack version-thread insights for this SDK base (
1.0.7-canary.*) are all CLIauto/inferred, i.e. a different CLI than this bump's pinned@github/copilot@1.0.71-2— so their CLI-attributed native-payload verdicts are treated as hypotheses only. The koffi packaging gap, however, is SDK-attributed (koffi is a@github/copilot-sdkdependency, CLI-independent), so it applies regardless of the CLI mismatch and matches the investigator's suggested action ("strip wrong-arch koffi inbuild/lib/copilot.ts"). The authoritative confirmation is the next def-111 product build against this exact SDK+CLI.No version pins or lockfiles were touched (Stage A owns those).