Check Agent Host dynamic dependencies#326084
Draft
roblourens wants to merge 1 commit into
Draft
Conversation
Include statically named dynamic imports in the remote Agent Host dependency graph while excluding exact dev-only and test-only imports. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the Agent Host packaging guard to trace literal dynamic imports while preserving narrowly scoped development/test exclusions.
Changes:
- Detects string and template-literal dynamic imports, including import attributes.
- Excludes two importer-specific non-production dependencies.
- Adds focused coverage for detection and exclusion scope.
Show a summary per file
| File | Description |
|---|---|
build/lib/test/agentHostDependencies.test.ts |
Expands dependency tracing and tests narrow dynamic-import exclusions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #326019.
Summary
import(...)calls in the remote Agent Host dependency graphTesting
cd build && npm run typecheckcd build && npm test(229 passing)npm run precommitnode-ptywhen that lazy dependency is removed fromremote/package.json(Written by Copilot)