agentHost: Preserve editor defaults on first send#326072
Merged
Merged
Conversation
Wait for in-flight provisional sessions before falling back to direct creation, and apply the same editor-window defaults on both paths. Keep explicit request configuration authoritative and make the provisional wait cancellation-aware. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents first-send races from bypassing editor session defaults.
Changes:
- Waits for provisional session creation with cancellation support.
- Merges editor defaults with authoritative request configuration.
- Adds focused regression tests.
Show a summary per file
| File | Description |
|---|---|
agentHostUntitledProvisionalSessionService.ts |
Exposes editor initial configuration. |
agentHostSessionHandler.ts |
Waits for provisional creation and merges defaults. |
agentHostUntitledProvisionalSessionService.test.ts |
Verifies provisional isolation defaults. |
agentHostChatContribution.test.ts |
Tests defaults, races, and cancellation. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Medium
Recheck cancellation after eager session hydration so a cancelled send cannot fall through to direct session creation. Add a regression test for cancellation while hydration is pending. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benvillalobos
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
A fast first send could race asynchronous provisional creation. When the fallback created the session without editor defaults, Git repositories inherited the provider's Worktree isolation default instead of the editor window's Folder isolation default.
Validation
npm run compilenpm run precommit(Written by Copilot)