chat: adopt provider-owned Agent Host read state in editor window#326071
Draft
roblourens wants to merge 2 commits into
Draft
chat: adopt provider-owned Agent Host read state in editor window#326071roblourens wants to merge 2 commits into
roblourens wants to merge 2 commits into
Conversation
Route editor-window read and unread mutations through Agent Host session item controllers, while preserving the existing local fallback for other providers. Reconcile optimistic state through AHP session summaries and cover delegation, model ownership, and refresh races.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adopts provider-owned Agent Host read state in editor-window session lists.
Changes:
- Adds controller APIs for read-state ownership and mutation.
- Projects and optimistically reconciles AHP read status.
- Adds focused delegation, state, and race tests.
Show a summary per file
| File | Description |
|---|---|
mockChatSessionsService.ts |
Mocks read-state delegation. |
chatSessionsService.test.ts |
Tests controller capability and delegation. |
agentSessionViewModel.test.ts |
Tests provider-authoritative read state. |
agentHostChatContribution.test.ts |
Tests AHP updates and refresh races. |
chatSessionsService.ts |
Defines read-state APIs. |
chatSessions.contribution.ts |
Implements controller delegation. |
agentSessionsModel.ts |
Integrates provider-owned state. |
agentHostSessionListStore.ts |
Adds optimistic status mutation. |
agentHostSessionListController.ts |
Projects and mutates AHP read state. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Medium
Reassert provider-owned read state when a later unread update arrives for an open chat, while preserving an explicit Mark as Unread action.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run typecheck-clientnpm run valid-layers-checknpm run precommitAdopts #325982 in the editor window.
(Written by Copilot)